mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.hengli.com.au>
To: Bandan Das <bandan.das@stratus.com>
Cc: bunk@kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
	David Miller <davem@davemloft.net>,
	NetDev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in ip_fragment
Date: Fri, 17 Sep 2010 14:51:17 +0800	[thread overview]
Message-ID: <20100917065117.GA9577@gondor.apana.org.au> (raw)
In-Reply-To: <20100915173209.GB9086@stratus.com>

On Wed, Sep 15, 2010 at 01:32:09PM -0400, Bandan Das wrote:
>
> Sorry for the late response. Here's a patch that I put up based on Herbert's
> suggestions. I ofcourse don't see the problem anymore after 
> commit 87f94b4e91dc042620c527f3c30c37e5127ef757 but a generic helper such as this 
> can be used anytime the bridge code is sending a packet over to the IP layer. 
> Compile tested only but based on responses, will test it before submitting a 
> final change. Also added it at two places where I know we do send a packet over to
> the IP layer. I will add it at other places later as I come across them.

Looks fine to me.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2010-09-17  6:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30 20:09 Bandan Das
2010-08-30 21:35 ` Eric Dumazet
2010-08-30 23:21   ` Bandan Das
2010-08-31  5:20     ` Eric Dumazet
2010-08-31  8:24       ` Herbert Xu
2010-08-31  9:17         ` Eric Dumazet
2010-08-31 12:36           ` Herbert Xu
2010-08-31 13:13             ` Eric Dumazet
2010-08-31 13:50               ` Bandan Das
2010-09-01 16:57             ` Bandan Das
2010-09-03  4:49               ` Herbert Xu
2010-09-15 17:32                 ` Bandan Das
2010-09-17  6:51                   ` Herbert Xu [this message]
2010-09-17 23:43                     ` David Miller
2010-09-19 19:36                       ` Bandan Das
2010-09-01 21:46       ` David Miller
2010-09-01 23:30         ` Herbert Xu
2010-09-02  1:09           ` David Miller
2010-09-02  2:05             ` Bandan Das
2010-09-02  2:17               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100917065117.GA9577@gondor.apana.org.au \
    --to=herbert@gondor.hengli.com.au \
    --cc=bandan.das@stratus.com \
    --cc=bunk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®