mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chase Douglas <chase.douglas@canonical.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Michael Poole <mdpoole@troilus.org>,
	Henrik Rydberg <rydberg@euromail.se>, Tejun Heo <tj@kernel.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/7 v3] HID: magicmouse: simplify multitouch feature request
Date: Tue, 31 Aug 2010 21:56:19 -0400	[thread overview]
Message-ID: <1283306184-28833-3-git-send-email-chase.douglas@canonical.com> (raw)
In-Reply-To: <1283306184-28833-1-git-send-email-chase.douglas@canonical.com>

From: Chase Douglas <chase.douglas@ubuntu.com>

Only the first feature request is required to put the Magic Mouse into
multitouch mode. This is also the case for the Magic Trackpad, for which
support will be added in a later commit.

Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
Acked-by: Michael Poole <mdpoole@troilus.org>
---
 drivers/hid/hid-magicmouse.c |   16 ++++------------
 1 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index d38b529..8a2fe78 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c
@@ -380,8 +380,7 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h
 static int magicmouse_probe(struct hid_device *hdev,
 	const struct hid_device_id *id)
 {
-	__u8 feature_1[] = { 0xd7, 0x01 };
-	__u8 feature_2[] = { 0xf8, 0x01, 0x32 };
+	__u8 feature[] = { 0xd7, 0x01 };
 	struct input_dev *input;
 	struct magicmouse_sc *msc;
 	struct hid_report *report;
@@ -426,17 +425,10 @@ static int magicmouse_probe(struct hid_device *hdev,
 	}
 	report->size = 6;
 
-	ret = hdev->hid_output_raw_report(hdev, feature_1, sizeof(feature_1),
+	ret = hdev->hid_output_raw_report(hdev, feature, sizeof(feature),
 			HID_FEATURE_REPORT);
-	if (ret != sizeof(feature_1)) {
-		dev_err(&hdev->dev, "unable to request touch data (1:%d)\n",
-				ret);
-		goto err_stop_hw;
-	}
-	ret = hdev->hid_output_raw_report(hdev, feature_2,
-			sizeof(feature_2), HID_FEATURE_REPORT);
-	if (ret != sizeof(feature_2)) {
-		dev_err(&hdev->dev, "unable to request touch data (2:%d)\n",
+	if (ret != sizeof(feature)) {
+		dev_err(&hdev->dev, "unable to request touch data (%d)\n",
 				ret);
 		goto err_stop_hw;
 	}
-- 
1.7.1


  parent reply	other threads:[~2010-09-01  1:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01  1:56 [PATCH 0/7 v3] HID: magicmouse: fixes and support for the Magic Trackpad (v3) Chase Douglas
2010-09-01  1:56 ` [PATCH 1/7 v3] HID: magicmouse: don't allow hidinput to initialize the device Chase Douglas
2010-09-01 18:01   ` Jiri Slaby
2010-09-01 23:57     ` Michael Poole
2010-09-02  9:28       ` Jiri Slaby
2010-09-02 12:06         ` Michael Poole
2010-09-03 11:25           ` Jiri Slaby
2010-09-04  1:10             ` Michael Poole
2010-09-05 15:16             ` [RFC PATCH] hid-magicmouse: Map inputs rather than munging input devices Michael Poole
2010-09-18 12:50               ` Chase Douglas
2010-09-01  1:56 ` Chase Douglas [this message]
2010-09-01  7:43   ` [PATCH 2/7 v3] HID: magicmouse: simplify multitouch feature request Henrik Rydberg
2010-09-01 12:34     ` Chase Douglas
2010-09-01 13:14       ` Henrik Rydberg
2010-09-01 13:50         ` Chase Douglas
2010-09-03 13:57   ` Jiri Kosina
2010-09-01  1:56 ` [PATCH 3/7 v3] HID: magicmouse: simplify touch data bit manipulation Chase Douglas
2010-09-03 14:07   ` Jiri Kosina
2010-09-01  1:56 ` [PATCH 4/7 v3] HID: magicmouse: simplify touch down logic Chase Douglas
2010-09-01  2:23   ` Michael Poole
2010-09-02 14:50     ` Jiri Kosina
2010-09-01  1:56 ` [PATCH 5/7 v3] HID: magicmouse: remove timestamp logic Chase Douglas
2010-09-01  2:24   ` Michael Poole
2010-09-02 14:52     ` Jiri Kosina
2010-09-01  1:56 ` [PATCH 6/7 v3] HID: magicmouse: enable Magic Trackpad support Chase Douglas
2010-09-03 14:05   ` Jiri Kosina
2010-09-01  1:56 ` [PATCH 7/7 v3] HID: magicmouse: Adjust major / minor axes to scale Chase Douglas
2010-09-02 14:55   ` Jiri Kosina
2010-09-07 13:50     ` Chase Douglas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283306184-28833-3-git-send-email-chase.douglas@canonical.com \
    --to=chase.douglas@canonical.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdpoole@troilus.org \
    --cc=rydberg@euromail.se \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®