mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chase Douglas <chase.douglas@canonical.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Michael Poole <mdpoole@troilus.org>,
	Henrik Rydberg <rydberg@euromail.se>, Tejun Heo <tj@kernel.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/7 v3] HID: magicmouse: remove timestamp logic
Date: Tue, 31 Aug 2010 21:56:22 -0400	[thread overview]
Message-ID: <1283306184-28833-6-git-send-email-chase.douglas@canonical.com> (raw)
In-Reply-To: <1283306184-28833-1-git-send-email-chase.douglas@canonical.com>

From: Chase Douglas <chase.douglas@ubuntu.com>

The timestamps from the device are currently stored in the private data
structure. These aren't used, so remove them. I've left a comment
detailing the protocol for future reference.

Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
 drivers/hid/hid-magicmouse.c |   18 +++++++-----------
 1 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index 0fbca59..9fc272f 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c
@@ -71,11 +71,6 @@ MODULE_PARM_DESC(report_undeciphered, "Report undeciphered multi-touch state fie
  * struct magicmouse_sc - Tracks Magic Mouse-specific data.
  * @input: Input device through which we report events.
  * @quirks: Currently unused.
- * @last_timestamp: Timestamp from most recent (18-bit) touch report
- *     (units of milliseconds over short windows, but seems to
- *     increase faster when there are no touches).
- * @delta_time: 18-bit difference between the two most recent touch
- *     reports from the mouse.
  * @ntouches: Number of touches in most recent touch report.
  * @scroll_accel: Number of consecutive scroll motions.
  * @scroll_jiffies: Time of last scroll motion.
@@ -86,8 +81,6 @@ struct magicmouse_sc {
 	struct input_dev *input;
 	unsigned long quirks;
 
-	int last_timestamp;
-	int delta_time;
 	int ntouches;
 	int scroll_accel;
 	unsigned long scroll_jiffies;
@@ -248,7 +241,7 @@ static int magicmouse_raw_event(struct hid_device *hdev,
 {
 	struct magicmouse_sc *msc = hid_get_drvdata(hdev);
 	struct input_dev *input = msc->input;
-	int x, y, ts, ii, clicks, npoints;
+	int x, y, ii, clicks, npoints;
 
 	switch (data[0]) {
 	case 0x10:
@@ -262,9 +255,6 @@ static int magicmouse_raw_event(struct hid_device *hdev,
 		/* Expect six bytes of prefix, and N*8 bytes of touch data. */
 		if (size < 6 || ((size - 6) % 8) != 0)
 			return 0;
-		ts = data[3] >> 6 | data[4] << 2 | data[5] << 10;
-		msc->delta_time = (ts - msc->last_timestamp) & 0x3ffff;
-		msc->last_timestamp = ts;
 		npoints = (size - 6) / 8;
 		msc->ntouches = 0;
 		for (ii = 0; ii < npoints; ii++)
@@ -280,6 +270,12 @@ static int magicmouse_raw_event(struct hid_device *hdev,
 		x = (int)(((data[3] & 0x0c) << 28) | (data[1] << 22)) >> 22;
 		y = (int)(((data[3] & 0x30) << 26) | (data[2] << 22)) >> 22;
 		clicks = data[3];
+
+		/* The following bits provide a device specific timestamp. They
+		 * are unused here.
+		 *
+		 * ts = data[3] >> 6 | data[4] << 2 | data[5] << 10;
+		 */
 		break;
 	case 0x20: /* Theoretically battery status (0-100), but I have
 		    * never seen it -- maybe it is only upon request.
-- 
1.7.1


  parent reply	other threads:[~2010-09-01  1:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01  1:56 [PATCH 0/7 v3] HID: magicmouse: fixes and support for the Magic Trackpad (v3) Chase Douglas
2010-09-01  1:56 ` [PATCH 1/7 v3] HID: magicmouse: don't allow hidinput to initialize the device Chase Douglas
2010-09-01 18:01   ` Jiri Slaby
2010-09-01 23:57     ` Michael Poole
2010-09-02  9:28       ` Jiri Slaby
2010-09-02 12:06         ` Michael Poole
2010-09-03 11:25           ` Jiri Slaby
2010-09-04  1:10             ` Michael Poole
2010-09-05 15:16             ` [RFC PATCH] hid-magicmouse: Map inputs rather than munging input devices Michael Poole
2010-09-18 12:50               ` Chase Douglas
2010-09-01  1:56 ` [PATCH 2/7 v3] HID: magicmouse: simplify multitouch feature request Chase Douglas
2010-09-01  7:43   ` Henrik Rydberg
2010-09-01 12:34     ` Chase Douglas
2010-09-01 13:14       ` Henrik Rydberg
2010-09-01 13:50         ` Chase Douglas
2010-09-03 13:57   ` Jiri Kosina
2010-09-01  1:56 ` [PATCH 3/7 v3] HID: magicmouse: simplify touch data bit manipulation Chase Douglas
2010-09-03 14:07   ` Jiri Kosina
2010-09-01  1:56 ` [PATCH 4/7 v3] HID: magicmouse: simplify touch down logic Chase Douglas
2010-09-01  2:23   ` Michael Poole
2010-09-02 14:50     ` Jiri Kosina
2010-09-01  1:56 ` Chase Douglas [this message]
2010-09-01  2:24   ` [PATCH 5/7 v3] HID: magicmouse: remove timestamp logic Michael Poole
2010-09-02 14:52     ` Jiri Kosina
2010-09-01  1:56 ` [PATCH 6/7 v3] HID: magicmouse: enable Magic Trackpad support Chase Douglas
2010-09-03 14:05   ` Jiri Kosina
2010-09-01  1:56 ` [PATCH 7/7 v3] HID: magicmouse: Adjust major / minor axes to scale Chase Douglas
2010-09-02 14:55   ` Jiri Kosina
2010-09-07 13:50     ` Chase Douglas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283306184-28833-6-git-send-email-chase.douglas@canonical.com \
    --to=chase.douglas@canonical.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdpoole@troilus.org \
    --cc=rydberg@euromail.se \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®