mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@amd.com>
To: <hpa@zytor.com>, <tglx@linutronix.de>, <mingo@elte.hu>
Cc: <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
	Andre Przywara <andre.przywara@amd.com>
Subject: [PATCH 3/4] x86: Fix allowed CPUID bits for KVM guests
Date: Mon, 6 Sep 2010 15:14:19 +0200	[thread overview]
Message-ID: <1283778860-26843-4-git-send-email-andre.przywara@amd.com> (raw)
In-Reply-To: <1283778860-26843-1-git-send-email-andre.przywara@amd.com>

The AMD extensions to AVX (FMA4, XOP) work on the same YMM register set
as AVX, so they are safe for guests to use, as long as AVX itself
is allowed. Add F16C and AES on the way for the same reasons.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>
---
 arch/x86/kvm/x86.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index dd54779..6c2ecf0 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1991,13 +1991,14 @@ static void do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
 		0 /* Reserved */ | F(CX16) | 0 /* xTPR Update, PDCM */ |
 		0 /* Reserved, DCA */ | F(XMM4_1) |
 		F(XMM4_2) | F(X2APIC) | F(MOVBE) | F(POPCNT) |
-		0 /* Reserved, AES */ | F(XSAVE) | 0 /* OSXSAVE */ | F(AVX);
+		0 /* Reserved*/ | F(AES) | F(XSAVE) | 0 /* OSXSAVE */ | F(AVX) |
+		F(F16C);
 	/* cpuid 0x80000001.ecx */
 	const u32 kvm_supported_word6_x86_features =
 		F(LAHF_LM) | F(CMP_LEGACY) | F(SVM) | 0 /* ExtApicSpace */ |
 		F(CR8_LEGACY) | F(ABM) | F(SSE4A) | F(MISALIGNSSE) |
 		F(3DNOWPREFETCH) | 0 /* OSVW */ | 0 /* IBS */ | F(XOP) |
-		0 /* SKINIT */ | 0 /* WDT */;
+		0 /* SKINIT, WDT, LWP */ | F(FMA4) | F(TBM);
 
 	/* all calls to cpuid_count() should be made on the same cpu */
 	get_cpu();
-- 
1.6.4



  parent reply	other threads:[~2010-09-06 13:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-06 13:14 [PATCH 0/4 -v2] x86: update AMD CPUID bits Andre Przywara
2010-09-06 13:14 ` [PATCH 1/4] x86: Fix misnamed AMD CPUID feature bit Andre Przywara
2010-09-08 21:27   ` [tip:x86/cpu] x86, cpu: Fix renamed, not-yet-shipping " tip-bot for Andre Przywara
2010-09-06 13:14 ` [PATCH 2/4] x86: Update AMD CPUID feature bits Andre Przywara
2010-09-08 21:28   ` [tip:x86/cpu] x86, cpu: " tip-bot for Andre Przywara
2010-09-06 13:14 ` Andre Przywara [this message]
2010-09-06 18:47   ` [PATCH 3/4] x86: Fix allowed CPUID bits for KVM guests Avi Kivity
2010-09-08 21:28   ` [tip:x86/cpu] x86, cpu: " tip-bot for Andre Przywara
2010-09-06 13:14 ` [PATCH 4/4] x86, kvm: add new AMD SVM feature bits Andre Przywara
2010-09-08 21:28   ` [tip:x86/cpu] " tip-bot for Andre Przywara
     [not found] <1283506069-1096-1-git-send-email-andre.przywara@amd.com>
     [not found] ` <1283506069-1096-4-git-send-email-andre.przywara@amd.com>
     [not found]   ` <4C8350C5.7050302@redhat.com>
2010-09-06 12:05     ` [PATCH 3/4] x86: Fix allowed CPUID bits for KVM guests Andre Przywara
2010-09-06 12:14       ` Avi Kivity
  -- strict thread matches above, loose matches on Subject: below --
2010-09-03  8:03 [PATCH 0/4] x86: update AMD CPUID bits Andre Przywara
2010-09-03  8:03 ` [PATCH 3/4] x86: Fix allowed CPUID bits for KVM guests Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283778860-26843-4-git-send-email-andre.przywara@amd.com \
    --to=andre.przywara@amd.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®