From: Namhyung Kim <namhyung@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>, Roland McGrath <roland@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH RESEND] signal: annotate siglock acquisition
Date: Sat, 25 Sep 2010 12:20:56 +0900 [thread overview]
Message-ID: <1285384856-4310-1-git-send-email-namhyung@gmail.com> (raw)
lock_task_sighand() conditionally acquires sighand->siglock in case of
returning non-NULL but unlock_task_sighand() releases it unconditionally.
This leads sparse to complain about the lock context imbalance. Annotate it
to make sparse happier.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
kernel/signal.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index bded651..766ae03 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1038,6 +1038,7 @@ int do_send_sig_info(int sig, struct siginfo *info, struct task_struct *p,
int ret = -ESRCH;
if (lock_task_sighand(p, &flags)) {
+ __acquire(&p->sighand->siglock); /* make sparse happy */
ret = send_signal(sig, info, p, group);
unlock_task_sighand(p, &flags);
}
@@ -1227,6 +1228,7 @@ int kill_pid_info_as_uid(int sig, struct siginfo *info, struct pid *pid,
if (sig) {
if (lock_task_sighand(p, &flags)) {
+ __acquire(&p->sighand->siglock);
ret = __send_signal(sig, info, p, 1, 0);
unlock_task_sighand(p, &flags);
} else
@@ -1406,6 +1408,8 @@ int send_sigqueue(struct sigqueue *q, struct task_struct *t, int group)
if (!likely(lock_task_sighand(t, &flags)))
goto ret;
+ __acquire(&t->sighand->siglock); /* make sparse happy */
+
ret = 1; /* the signal is ignored */
if (!prepare_signal(sig, t, 0))
goto out;
--
1.7.2.2
next reply other threads:[~2010-09-25 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 3:20 Namhyung Kim [this message]
2010-09-25 3:26 ` Al Viro
2010-09-25 3:44 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285384856-4310-1-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®