From: Al Viro <viro@ZenIV.linux.org.uk>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] signal: annotate siglock acquisition
Date: Sat, 25 Sep 2010 04:26:38 +0100 [thread overview]
Message-ID: <20100925032638.GT19804@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1285384856-4310-1-git-send-email-namhyung@gmail.com>
On Sat, Sep 25, 2010 at 12:20:56PM +0900, Namhyung Kim wrote:
> lock_task_sighand() conditionally acquires sighand->siglock in case of
> returning non-NULL but unlock_task_sighand() releases it unconditionally.
> This leads sparse to complain about the lock context imbalance. Annotate it
> to make sparse happier.
That's not a good way to do it; use __cond_lock instead.
next prev parent reply other threads:[~2010-09-25 3:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 3:20 Namhyung Kim
2010-09-25 3:26 ` Al Viro [this message]
2010-09-25 3:44 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100925032638.GT19804@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®