mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Kennedy <richard@rsk.demon.co.uk>
To: Eric Paris <eparis@redhat.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [Patch] fsnotify: remove alignment padding from fsnotify_mark on 64 bit builds
Date: Tue, 28 Sep 2010 15:00:02 +0100	[thread overview]
Message-ID: <1285682402.1878.11.camel@castor.rsk> (raw)

Reorder struct fsnotfiy_mark to remove 8 bytes of alignment padding on
64 bit builds.
Shrinks fsnotfiy_mark to 128 bytes allowing more objects per slab in its
kmem_cache and reduces the number of cachelines needed for each
structure.
    
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
----

Hi Eric,
patch against 2.6.36-rc5
compiled & booted on x86_64.

I'm not sure how to test this, but it boots and I think it's safe to
make this change.

regards
Richard



diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h
index e40190d..369bed5 100644
--- a/include/linux/fsnotify_backend.h
+++ b/include/linux/fsnotify_backend.h
@@ -275,8 +275,8 @@ struct fsnotify_mark {
 		struct fsnotify_inode_mark i;
 		struct fsnotify_vfsmount_mark m;
 	};
-	__u32 ignored_mask;		/* events types to ignore */
 	struct list_head free_g_list;	/* tmp list used when freeing this mark */
+	__u32 ignored_mask;		/* events types to ignore */
 #define FSNOTIFY_MARK_FLAG_INODE		0x01
 #define FSNOTIFY_MARK_FLAG_VFSMOUNT		0x02
 #define FSNOTIFY_MARK_FLAG_OBJECT_PINNED	0x04



                 reply	other threads:[~2010-09-28 14:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285682402.1878.11.camel@castor.rsk \
    --to=richard@rsk.demon.co.uk \
    --cc=eparis@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®