mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [Patch] fsnotify: remove alignment padding from fsnotify_mark on 64 bit builds
@ 2010-09-28 14:00 Richard Kennedy
  0 siblings, 0 replies; only message in thread
From: Richard Kennedy @ 2010-09-28 14:00 UTC (permalink / raw)
  To: Eric Paris; +Cc: lkml

Reorder struct fsnotfiy_mark to remove 8 bytes of alignment padding on
64 bit builds.
Shrinks fsnotfiy_mark to 128 bytes allowing more objects per slab in its
kmem_cache and reduces the number of cachelines needed for each
structure.
    
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
----

Hi Eric,
patch against 2.6.36-rc5
compiled & booted on x86_64.

I'm not sure how to test this, but it boots and I think it's safe to
make this change.

regards
Richard



diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h
index e40190d..369bed5 100644
--- a/include/linux/fsnotify_backend.h
+++ b/include/linux/fsnotify_backend.h
@@ -275,8 +275,8 @@ struct fsnotify_mark {
 		struct fsnotify_inode_mark i;
 		struct fsnotify_vfsmount_mark m;
 	};
-	__u32 ignored_mask;		/* events types to ignore */
 	struct list_head free_g_list;	/* tmp list used when freeing this mark */
+	__u32 ignored_mask;		/* events types to ignore */
 #define FSNOTIFY_MARK_FLAG_INODE		0x01
 #define FSNOTIFY_MARK_FLAG_VFSMOUNT		0x02
 #define FSNOTIFY_MARK_FLAG_OBJECT_PINNED	0x04



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-09-28 14:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-28 14:00 [Patch] fsnotify: remove alignment padding from fsnotify_mark on 64 bit builds Richard Kennedy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®