* [PATCH] jbd: Move debug message into #ifdef area
@ 2010-10-04 8:26 Namhyung Kim
2010-10-04 9:39 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Namhyung Kim @ 2010-10-04 8:26 UTC (permalink / raw)
To: Andrew Morton, Jan Kara; +Cc: linux-ext4, linux-kernel
Move call to jbd_debug() into #ifdef CONFIG_JBD_DEBUG block because
'dropped' is declared there. The code could be compiled without this
change anyway, simply because jbd_debug() expands to nothing if
!CONFIG_JBD_DEBUG but IMHO it doesn't look good in general.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
fs/jbd/recovery.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/jbd/recovery.c b/fs/jbd/recovery.c
index 81051da..5b43e96 100644
--- a/fs/jbd/recovery.c
+++ b/fs/jbd/recovery.c
@@ -296,10 +296,10 @@ int journal_skip_recovery(journal_t *journal)
#ifdef CONFIG_JBD_DEBUG
int dropped = info.end_transaction -
be32_to_cpu(journal->j_superblock->s_sequence);
-#endif
jbd_debug(1,
"JBD: ignoring %d transaction%s from the journal.\n",
dropped, (dropped == 1) ? "" : "s");
+#endif
journal->j_transaction_sequence = ++info.end_transaction;
}
--
1.7.0.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] jbd: Move debug message into #ifdef area
2010-10-04 8:26 [PATCH] jbd: Move debug message into #ifdef area Namhyung Kim
@ 2010-10-04 9:39 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2010-10-04 9:39 UTC (permalink / raw)
To: Namhyung Kim; +Cc: Andrew Morton, Jan Kara, linux-ext4, linux-kernel
On Mon 04-10-10 17:26:53, Namhyung Kim wrote:
> Move call to jbd_debug() into #ifdef CONFIG_JBD_DEBUG block because
> 'dropped' is declared there. The code could be compiled without this
> change anyway, simply because jbd_debug() expands to nothing if
> !CONFIG_JBD_DEBUG but IMHO it doesn't look good in general.
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Thanks. Merged into my tree.
Honza
> ---
> fs/jbd/recovery.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/jbd/recovery.c b/fs/jbd/recovery.c
> index 81051da..5b43e96 100644
> --- a/fs/jbd/recovery.c
> +++ b/fs/jbd/recovery.c
> @@ -296,10 +296,10 @@ int journal_skip_recovery(journal_t *journal)
> #ifdef CONFIG_JBD_DEBUG
> int dropped = info.end_transaction -
> be32_to_cpu(journal->j_superblock->s_sequence);
> -#endif
> jbd_debug(1,
> "JBD: ignoring %d transaction%s from the journal.\n",
> dropped, (dropped == 1) ? "" : "s");
> +#endif
> journal->j_transaction_sequence = ++info.end_transaction;
> }
>
> --
> 1.7.0.4
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-04 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-04 8:26 [PATCH] jbd: Move debug message into #ifdef area Namhyung Kim
2010-10-04 9:39 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®