* [PATCH 5/6] intel_mid_dma: fix the WARN_ONs
@ 2010-10-04 10:38 Vinod Koul
0 siblings, 0 replies; only message in thread
From: Vinod Koul @ 2010-10-04 10:38 UTC (permalink / raw)
To: dan.j.williams, linux-kernel, alan, ramesh.b.k.v, yong.y.wang; +Cc: Vinod Koul
Moved the WARN_ON to BUG_ON, as WARN_ON if hit,
can cause null pointer derefrences
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/dma/intel_mid_dma.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c
index 2ae1086..ef7ffb8 100644
--- a/drivers/dma/intel_mid_dma.c
+++ b/drivers/dma/intel_mid_dma.c
@@ -581,15 +581,15 @@ static struct dma_async_tx_descriptor *intel_mid_dma_prep_memcpy(
enum intel_mid_dma_width width = 0;
pr_debug("MDMA: Prep for memcpy\n");
- WARN_ON(!chan);
+ BUG_ON(!chan);
if (!len)
return NULL;
mids = chan->private;
- WARN_ON(!mids);
+ BUG_ON(!mids);
midc = to_intel_mid_dma_chan(chan);
- WARN_ON(!midc);
+ BUG_ON(!midc);
pr_debug("MDMA:called for DMA %x CH %d Length %zu\n",
midc->dma->pci_id, midc->ch_id, len);
--
1.6.6.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-10-04 10:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-04 10:38 [PATCH 5/6] intel_mid_dma: fix the WARN_ONs Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®