From: Evgeny Kuznetsov <EXT-Eugeny.Kuznetsov@nokia.com>
To: balbi@ti.com
Cc: "tony@atomide.com" <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"zmc@lurian.net" <zmc@lurian.net>,
"a.j.buxton@gmail.com" <a.j.buxton@gmail.com>
Subject: Re: [PATCH 1/1] omap: Ptr "isr_reg" tracked as NULL was dereferenced
Date: Tue, 05 Oct 2010 13:55:19 +0400 [thread overview]
Message-ID: <1286272519.24366.33.camel@ekuznets-lx-nokia> (raw)
In-Reply-To: <20101005093206.GB2977@legolas.emea.dhcp.ti.com>
Hi,
Yes, but no log in that case.
Regards,
Evgeny
On Tue, 2010-10-05 at 12:32 +0300, ext Felipe Balbi wrote:
> Hi,
>
> On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
> >+ if (!isr_reg) {
> >+ printk(KERN_ERR "FATAL: Incorrect GPIO method %i\n",
> >+ bank->method);
> >+ BUG();
> >+ }
>
> this could be simply:
>
> BUG_ON(!isr_reg);
>
next prev parent reply other threads:[~2010-10-05 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 8:42 [PATCH 0/1] " Evgeny Kuznetsov
2010-10-05 8:42 ` [PATCH 1/1] " Evgeny Kuznetsov
2010-10-05 9:32 ` Felipe Balbi
2010-10-05 9:55 ` Evgeny Kuznetsov [this message]
2010-10-05 11:48 ` Felipe Balbi
2010-10-05 15:01 ` Kevin Hilman
2010-10-06 6:33 ` Evgeny Kuznetsov
2010-10-08 7:49 ` Evgeny Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286272519.24366.33.camel@ekuznets-lx-nokia \
--to=ext-eugeny.kuznetsov@nokia.com \
--cc=a.j.buxton@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=balbi@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=zmc@lurian.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®