mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: Tvrtko Ursulin <tvrtko.ursulin@sophos.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	agruen@suse.de
Subject: Re: Linux 2.6.36-rc7
Date: Thu, 07 Oct 2010 13:33:55 -0400	[thread overview]
Message-ID: <1286472835.2656.15.camel@dhcp231-98.rdu.redhat.com> (raw)
In-Reply-To: <201010071815.54303.tvrtko.ursulin@sophos.com>

On Thu, 2010-10-07 at 18:15 +0100, Tvrtko Ursulin wrote:
> On Thursday 07 Oct 2010 17:10:46 Tvrtko Ursulin wrote:
> > On Wednesday 06 Oct 2010 22:45:13 Linus Torvalds wrote:

> Priority argument was dropped from the fanotify_init syscall, and since it is
> a syscall once released it is set in stone. Without the priority argument, how
> are multiple clients supposed to be ordered?
> 
> Co-existence between multiple clients was something which was supposed to be
> designed in from the start. Use cases like hierarchical storage management,
> anti-malware and content indexing should all be able to co-exist. Without a
> priority argument I do not see how it can be assured HSM sees the perm event
> before anti-malware, and content indexing after both of them? If there was any
> discussion about dropping priority I missed it. :(

Shit.  I'm trying to remember the logic.  hrmph....   You could have a
real interface issue....  Shit.  Let me think about it for an hour or
two.

Original idea of priorities was to allow multiple permissions decision
makers to co-exist without having the livelock problem of each trying to
grant and deny access to each other.  That was solved with the
O_NONOTIFY hack and I think the priority was then thought to be useless.
But you're absolutely right, it isn't useless if we consider that an HSM
might need to run first to make sure data exists on disk before an
indexer looks at the data.

I see two possibilities off the top of my head:

I could just slap an (unused) priority field onto the end of the
fanotify_init() syscall (assuming Linus doesn't murder me) so we can
build that support out with explicit priorities down the line, which I
think might be overkill, or

The other option (without breaking ABI as it stands today) is to define
some set of the fanotify_init() flags to be a priority field, we've got
32 bits and only use 2 of them so giving 4-8 bits of that as a priority
(next cycle) isn't an issue and can be easily backwards compatible.

-Eric


  reply	other threads:[~2010-10-07 17:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 21:45 Linus Torvalds
2010-10-07  0:49 ` Stephen Rothwell
2010-10-08 15:05   ` James Bottomley
2010-10-07 16:10 ` Tvrtko Ursulin
2010-10-07 17:15   ` Tvrtko Ursulin
2010-10-07 17:33     ` Eric Paris [this message]
2010-10-07 18:07       ` Alan Cox
2010-10-07 17:49         ` Eric Paris
2010-10-08 12:06           ` Andreas Gruenbacher
2010-10-08 16:33             ` David Daney
2010-10-08 21:50               ` Andreas Gruenbacher
2010-10-08 21:59                 ` H. Peter Anvin
2010-10-11 22:13                   ` fanotify: disable fanotify syscalls Eric Paris
2010-10-08 16:38             ` Linux 2.6.36-rc7 Eric Paris
2010-10-08 21:45               ` Andreas Gruenbacher
2010-10-07 20:55       ` John Stoffel
2010-10-07 21:24         ` Eric Paris
2010-10-08 15:42           ` John Stoffel
2010-10-08 16:17             ` Tvrtko Ursulin
2010-10-08 16:41               ` Eric Paris
2010-10-18 11:01                 ` Tvrtko Ursulin
2010-10-08 16:54               ` John Stoffel
2010-10-08 21:03               ` Andreas Gruenbacher
2010-10-09  0:46                 ` John Stoffel
2010-10-07 19:28 ` Tejun Heo
2010-10-07 20:13   ` [dm-devel] " Milan Broz
2010-10-08 17:02     ` Tejun Heo
2010-10-10 11:56       ` Torsten Kaiser
2010-10-11 10:09       ` [PATCH wq#for-next] workqueue: fix HIGHPRI handling in keep_working() Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286472835.2656.15.camel@dhcp231-98.rdu.redhat.com \
    --to=eparis@redhat.com \
    --cc=agruen@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tvrtko.ursulin@sophos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®