* [PATCH 1/3] Staging: speakup: Makefile: Makefile clean up @ 2010-10-08 10:13 Tracey Dent 2010-10-08 10:13 ` [PATCH 2/3] Staging: speakup: devsynth: file_operations should be const Tracey Dent 2010-10-08 10:13 ` [PATCH 3/3] Staging: speakup: keyhelp: Coding style fix Tracey Dent 0 siblings, 2 replies; 4+ messages in thread From: Tracey Dent @ 2010-10-08 10:13 UTC (permalink / raw) To: greg; +Cc: linux-kernel, Tracey Dent Replaced <modules>-objs with <modules>-y in Makefile. --- drivers/staging/speakup/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/speakup/Makefile b/drivers/staging/speakup/Makefile index 9923463..c5e43a5 100644 --- a/drivers/staging/speakup/Makefile +++ b/drivers/staging/speakup/Makefile @@ -15,7 +15,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += speakup_txprt.o obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o obj-$(CONFIG_SPEAKUP) += speakup.o -speakup-objs := \ +speakup-y := \ buffers.o \ devsynth.o \ i18n.o \ -- 1.7.3.1.104.gc752e ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/3] Staging: speakup: devsynth: file_operations should be const 2010-10-08 10:13 [PATCH 1/3] Staging: speakup: Makefile: Makefile clean up Tracey Dent @ 2010-10-08 10:13 ` Tracey Dent 2010-10-08 10:13 ` [PATCH 3/3] Staging: speakup: keyhelp: Coding style fix Tracey Dent 1 sibling, 0 replies; 4+ messages in thread From: Tracey Dent @ 2010-10-08 10:13 UTC (permalink / raw) To: greg; +Cc: linux-kernel, Tracey Dent Fixed file_operation struct, so that it is const. --- drivers/staging/speakup/devsynth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/speakup/devsynth.c b/drivers/staging/speakup/devsynth.c index a465653..8b74622 100644 --- a/drivers/staging/speakup/devsynth.c +++ b/drivers/staging/speakup/devsynth.c @@ -56,7 +56,7 @@ static int speakup_file_release(struct inode *ip, struct file *fp) return 0; } -static struct file_operations synth_fops = { +static const struct file_operations synth_fops = { .read = speakup_file_read, .write = speakup_file_write, .open = speakup_file_open, -- 1.7.3.1.104.gc752e ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3/3] Staging: speakup: keyhelp: Coding style fix 2010-10-08 10:13 [PATCH 1/3] Staging: speakup: Makefile: Makefile clean up Tracey Dent 2010-10-08 10:13 ` [PATCH 2/3] Staging: speakup: devsynth: file_operations should be const Tracey Dent @ 2010-10-08 10:13 ` Tracey Dent 1 sibling, 0 replies; 4+ messages in thread From: Tracey Dent @ 2010-10-08 10:13 UTC (permalink / raw) To: greg; +Cc: linux-kernel, Tracey Dent Put { on previous line, on line 34. Checkpatch.pl caught this. --- drivers/staging/speakup/keyhelp.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/keyhelp.c b/drivers/staging/speakup/keyhelp.c index 81c627c..a74500a 100644 --- a/drivers/staging/speakup/keyhelp.c +++ b/drivers/staging/speakup/keyhelp.c @@ -30,11 +30,11 @@ static const int num_key_names = MSG_KEYNAMES_END - MSG_KEYNAMES_START + 1; static u_short key_offsets[MAXFUNCS], key_data[MAXKEYS]; static u_short masks[] = { 32, 16, 8, 4, 2, 1 }; -static short letter_offsets[26] = -{ -1, -1, -1, -1, -1, -1, -1, -1, - -1, -1, -1, -1, -1, -1, -1, -1, - -1, -1, -1, -1, -1, -1, -1, -1, - -1, -1 }; +static short letter_offsets[26] = { + -1, -1, -1, -1, -1, -1, -1, -1, + -1, -1, -1, -1, -1, -1, -1, -1, + -1, -1, -1, -1, -1, -1, -1, -1, + -1, -1 }; static u_char funcvals[] = { ATTRIB_BLEEP_DEC, ATTRIB_BLEEP_INC, BLEEPS_DEC, BLEEPS_INC, -- 1.7.3.1.104.gc752e ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] Staging: speakup: Makefile: Makefile clean up @ 2010-10-08 10:14 Tracey Dent 0 siblings, 0 replies; 4+ messages in thread From: Tracey Dent @ 2010-10-08 10:14 UTC (permalink / raw) To: greg; +Cc: linux-kernel, Tracey Dent Replaced <modules>-objs with <modules>-y in Makefile. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/speakup/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/speakup/Makefile b/drivers/staging/speakup/Makefile index 9923463..c5e43a5 100644 --- a/drivers/staging/speakup/Makefile +++ b/drivers/staging/speakup/Makefile @@ -15,7 +15,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += speakup_txprt.o obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o obj-$(CONFIG_SPEAKUP) += speakup.o -speakup-objs := \ +speakup-y := \ buffers.o \ devsynth.o \ i18n.o \ -- 1.7.3.1.104.gc752e ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-08 10:14 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-10-08 10:13 [PATCH 1/3] Staging: speakup: Makefile: Makefile clean up Tracey Dent 2010-10-08 10:13 ` [PATCH 2/3] Staging: speakup: devsynth: file_operations should be const Tracey Dent 2010-10-08 10:13 ` [PATCH 3/3] Staging: speakup: keyhelp: Coding style fix Tracey Dent 2010-10-08 10:14 [PATCH 1/3] Staging: speakup: Makefile: Makefile clean up Tracey Dent
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®