get_maintainer

get_maintainer

[Johannes Berg]

Joe,

get_maintainer.pl has a huge amount of false positives, and as a net
result people CC me on *all* wireless driver patches (when they use the
script) because I've touched them all in commits like 97359d1235eaf634f.

Would it be possible to modify the script to actually look at the
patches it found and not CC people if the changes to the file in
question are, say, less than 20% of the overall patch?

If that turns out to not be possible, I think I'm going to have to cook
up blacklist support for it ... :-)

johannes

Re: get_maintainer

[Joe Perches]

On Mon, 2010-10-11 at 11:36 +0200, Johannes Berg wrote:
> Would it be possible to modify the script to actually look at the
> patches it found and not CC people if the changes to the file in
> question are, say, less than 20% of the overall patch?

Hi Johannes.

Pull this in some test branch and try it out.

git://repo.or.cz/linux-2.6/get_maintainer.git 20100922_gm

If you try this and find it less than adequate,
please tell me why.

Here's the patch series, which is in MM
http://lkml.org/lkml/2010/9/22/464

Here's a couple of recent longish threads about this.
http://lkml.org/lkml/2010/9/10/94
http://lkml.org/lkml/2010/9/25/184

Re: get_maintainer

[Johannes Berg]

Hi Joe,

> Pull this in some test branch and try it out.
> 
> git://repo.or.cz/linux-2.6/get_maintainer.git 20100922_gm
> 
> If you try this and find it less than adequate,
> please tell me why.

> Here's a couple of recent longish threads about this.
> http://lkml.org/lkml/2010/9/10/94
> http://lkml.org/lkml/2010/9/25/184

Oh my, I missed that.

I tried it out, and it seems --git is no longer default. That in itself
will probably help lots already, and somebody using non-default options
will hopefully pay more attention.

Thanks!

Johannes