mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] pcmcia: fix unused function compile warning
@ 2010-10-14  4:47 Maciej Żenczykowski
  2010-10-14  9:47 ` Dominik Brodowski
  0 siblings, 1 reply; 2+ messages in thread
From: Maciej Żenczykowski @ 2010-10-14  4:47 UTC (permalink / raw)
  To: Dominik Brodowski, Linus Torvalds, linux-pcmcia, linux-kernel
  Cc: Maciej Żenczykowski

pcmcia_socket_dev_resume() is only referenced from macro
SET_SYSTEM_SLEEP_PM_OPS(NULL, pcmcia_socket_dev_resume)
which based on CONFIG_PM_SLEEP may or may not actually
use its second parameter.

Signed-off-by: Maciej Żenczykowski <zenczykowski@gmail.com>
---
 drivers/pcmcia/cs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c
index 2ec8ac9..1aaa4a9 100644
--- a/drivers/pcmcia/cs.c
+++ b/drivers/pcmcia/cs.c
@@ -845,7 +845,7 @@ static int pcmcia_socket_dev_resume_noirq(struct device *dev)
 	return __pcmcia_pm_op(dev, socket_early_resume);
 }
 
-static int pcmcia_socket_dev_resume(struct device *dev)
+static int __used pcmcia_socket_dev_resume(struct device *dev)
 {
 	return __pcmcia_pm_op(dev, socket_late_resume);
 }
-- 
1.7.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] pcmcia: fix unused function compile warning
  2010-10-14  4:47 [PATCH] pcmcia: fix unused function compile warning Maciej Żenczykowski
@ 2010-10-14  9:47 ` Dominik Brodowski
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Brodowski @ 2010-10-14  9:47 UTC (permalink / raw)
  To: Maciej Żenczykowski; +Cc: Linus Torvalds, linux-pcmcia, linux-kernel

On Wed, Oct 13, 2010 at 09:47:14PM -0700, Maciej Żenczykowski wrote:
> pcmcia_socket_dev_resume() is only referenced from macro
> SET_SYSTEM_SLEEP_PM_OPS(NULL, pcmcia_socket_dev_resume)
> which based on CONFIG_PM_SLEEP may or may not actually
> use its second parameter.
> 
> Signed-off-by: Maciej Żenczykowski <zenczykowski@gmail.com>

Applied to the pcmcia git tree, thanks.

Best,
	Dominik

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-10-14  9:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-14  4:47 [PATCH] pcmcia: fix unused function compile warning Maciej Żenczykowski
2010-10-14  9:47 ` Dominik Brodowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®