From: Milan Broz <mbroz@redhat.com>
To: axboe@kernel.dk
Cc: jeff.chua.linux@gmail.com, hch@lst.de,
linux-kernel@vger.kernel.org, Milan Broz <mbroz@redhat.com>
Subject: [PATCH] loop: Properly clear sysfs in autoclear mode
Date: Mon, 25 Oct 2010 09:11:38 +0200 [thread overview]
Message-ID: <1287990698-21690-1-git-send-email-mbroz@redhat.com> (raw)
In-Reply-To: <20101023155950.GA31946@lst.de>
In autoclear mode bdev is NULL but the sysfs
entry should be destroyed otherwise this warning appears:
WARNING: at fs/sysfs/dir.c:451 sysfs_add_one+0x82/0x95()
sysfs: cannot create duplicate filename '/devices/virtual/block/loop0/loop'
Fixes commit ee86273062cbb310665fe49e1f1937d2cf85b0b9
Signed-off-by: Milan Broz <mbroz@redhat.com>
---
drivers/block/loop.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 6c48b35..c21d4f3 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1049,9 +1049,9 @@ static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev)
if (bdev)
invalidate_bdev(bdev);
set_capacity(lo->lo_disk, 0);
+ loop_sysfs_exit(lo);
if (bdev) {
bd_set_size(bdev, 0);
- loop_sysfs_exit(lo);
/* let user-space know about this change */
kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE);
}
--
1.7.2.3
next prev parent reply other threads:[~2010-10-25 7:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 15:59 loop warnings in current git HEAD Christoph Hellwig
2010-10-24 10:02 ` Milan Broz
2010-10-24 16:13 ` Christoph Hellwig
2010-10-24 16:18 ` Milan Broz
2010-10-25 7:11 ` Milan Broz [this message]
2010-10-25 12:41 ` [PATCH] loop: Properly clear sysfs in autoclear mode Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287990698-21690-1-git-send-email-mbroz@redhat.com \
--to=mbroz@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jeff.chua.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®