From: Milan Broz <mbroz@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: jaxboe@fusionio.com, linux-kernel@vger.kernel.org
Subject: Re: loop warnings in current git HEAD
Date: Sun, 24 Oct 2010 18:18:52 +0200 [thread overview]
Message-ID: <4CC45C6C.6030006@redhat.com> (raw)
In-Reply-To: <20101024161323.GA32405@lst.de>
On 10/24/2010 06:13 PM, Christoph Hellwig wrote:
> On Sun, Oct 24, 2010 at 12:02:39PM +0200, Milan Broz wrote:
>> yes, seems I forgot bdev can be NULL in destructor (autoclear mode).
>> can you try if patch below helps?
>
> Yes, this patch seems to fix the issue for me.
Great.
Jens, please can you queue it to block git then?
Btw there seems to be other loop problem I just found (not related to my patch)
when loop compiled as module oopses on unload, I'll try to bisect it.
Milan
next prev parent reply other threads:[~2010-10-24 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 15:59 Christoph Hellwig
2010-10-24 10:02 ` Milan Broz
2010-10-24 16:13 ` Christoph Hellwig
2010-10-24 16:18 ` Milan Broz [this message]
2010-10-25 7:11 ` [PATCH] loop: Properly clear sysfs in autoclear mode Milan Broz
2010-10-25 12:41 ` Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC45C6C.6030006@redhat.com \
--to=mbroz@redhat.com \
--cc=hch@lst.de \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome