From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Alex Dubov <oakad@yahoo.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: memstick: Alternative approach to proposed fixes
Date: Wed, 27 Oct 2010 00:55:39 +0200 [thread overview]
Message-ID: <1288133739.15918.3.camel@maxim-laptop> (raw)
In-Reply-To: <1288114871-805-1-git-send-email-oakad@yahoo.com>
On Wed, 2010-10-27 at 04:41 +1100, Alex Dubov wrote:
> As I was not able to convince myself that profound changes proposed by Maxim
> are really necessary, I propose to follow a much milder path with this update
> round (as I outlined in my previous emails).
It is really sad to see that patchset.
>
> In this small patchset, I fix a couple of small omissions as well as introduce
> support for "extended command" MSPro transfer method (currently enabled for
> JMicron, but I'll clear the TI host for this functionality soon). I expect the
> current solution to scale trivially for HG and XC transfer methods (I don't
> have the spec for the later yet).
Indeed small.
All the changes in this patchset are really minor and optional.
I could have dropped them.
I did much more that that.
I made the memstick code readable so not only you could understand it
I also wrote ms_block.c while adding common support.
I made your code use that support.
It is really sad that you are doing that.
next prev parent reply other threads:[~2010-10-26 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 17:41 Alex Dubov
2010-10-26 17:41 ` [PATCH 1/4] memstick: avert possible race condition between idr_pre_get and idr_get_new Alex Dubov
2010-10-26 17:41 ` [PATCH 2/4] memstick: remove mspro_block_mutex Alex Dubov
2010-10-26 17:41 ` [PATCH 3/4] memstick: factor out transfer initiating functionality in mspro_block.c Alex Dubov
2010-10-26 17:41 ` [PATCH 4/4] memstick: add support for MSPro specific data transfer method Alex Dubov
2010-10-26 22:55 ` Maxim Levitsky [this message]
2010-10-26 23:07 ` memstick: Alternative approach to proposed fixes Maxim Levitsky
2010-10-26 23:08 ` Maxim Levitsky
2010-10-27 6:20 ` Alex Dubov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288133739.15918.3.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oakad@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®