From: Alex Dubov <oakad@yahoo.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: memstick: Alternative approach to proposed fixes
Date: Tue, 26 Oct 2010 23:20:16 -0700 (PDT) [thread overview]
Message-ID: <882321.18802.qm@web37604.mail.mud.yahoo.com> (raw)
In-Reply-To: <1288133739.15918.3.camel@maxim-laptop>
> All the changes in this patchset are really minor and
> optional.
> I could have dropped them.
These are the only substantial fixes you patchset has. The rest of the
large submission is your unilateral decision to rewrite the whole thing
almost from scratch. I proposed, multiple times, to fix the small things
first, then discuss the long term evolution.
>
>
> I did much more that that.
> I made the memstick code readable so not only you could
> understand it
> I also wrote ms_block.c while adding common support.
> I made your code use that support.
>
> It is really sad that you are doing that.
>
>
>
>
prev parent reply other threads:[~2010-10-27 6:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 17:41 Alex Dubov
2010-10-26 17:41 ` [PATCH 1/4] memstick: avert possible race condition between idr_pre_get and idr_get_new Alex Dubov
2010-10-26 17:41 ` [PATCH 2/4] memstick: remove mspro_block_mutex Alex Dubov
2010-10-26 17:41 ` [PATCH 3/4] memstick: factor out transfer initiating functionality in mspro_block.c Alex Dubov
2010-10-26 17:41 ` [PATCH 4/4] memstick: add support for MSPro specific data transfer method Alex Dubov
2010-10-26 22:55 ` memstick: Alternative approach to proposed fixes Maxim Levitsky
2010-10-26 23:07 ` Maxim Levitsky
2010-10-26 23:08 ` Maxim Levitsky
2010-10-27 6:20 ` Alex Dubov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=882321.18802.qm@web37604.mail.mud.yahoo.com \
--to=oakad@yahoo.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome