From: Joe Perches <joe@perches.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <trivial@kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use
Date: Tue, 26 Oct 2010 18:35:45 -0700 [thread overview]
Message-ID: <1288143345.4145.90.camel@Joe-Laptop> (raw)
In-Reply-To: <4E27039C-DE6B-4C90-ADC5-68D3B30F75E6@gmail.com>
On Tue, 2010-10-26 at 18:28 -0700, Dmitry Torokhov wrote:
> On Oct 26, 2010, at 6:10 PM, Joe Perches <joe@perches.com> wrote:
> > I think 2 defects in 16 uses is a pretty high error rate.
> But how not adding /n is it much better than having it if
> some later change will forget to add it to the message?
Adding \n is the default kernel style.
USB uses a similar dbg macro with a relatively
high error rate.
I fixed some in this commit below awhile ago,
but these keep creeping back in, so they _are_
error prone in actual use.
commit 759f3634267a67ac90f3fa7fc06510dfd43b4e45
Author: Joe Perches <joe@perches.com>
Date: Fri Feb 5 16:50:08 2010 -0800
USB: serial: Remove unnecessary \n's from dbg uses
#define dbg adds the newline, messages shouldn't.
Converted dbg("%s", "some string") to dbg("some string")
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
next prev parent reply other threads:[~2010-10-27 1:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 2:44 [PATCH 00/10] Remove multiple uses of KERN_<level> Joe Perches
2010-10-26 2:44 ` [PATCH 01/10] arch/x86/kernel/apic/io_apic.c: Typo fix WARNING Joe Perches
2010-10-26 7:48 ` Ingo Molnar
2010-10-26 8:23 ` Joe Perches
2010-10-26 2:44 ` [PATCH 02/10] drivers/atm/eni.c: Remove multiple uses of KERN_<level> Joe Perches
2010-10-26 2:44 ` [PATCH 03/10] drivers/hid/hid-input.c: Remove KERN_DEBUG from dbg_hid use Joe Perches
2010-11-03 14:13 ` Jiri Kosina
2010-10-26 2:44 ` [PATCH 04/10] drivers/infiniband: Remove unnecessary KERN_<level> uses Joe Perches
2010-10-26 11:29 ` Steve Wise
2010-10-26 20:46 ` Roland Dreier
2010-10-26 2:44 ` [PATCH 05/10] drivers/input/mouse/appletouch.c: Remove KERN_DEBUG use from dprintk Joe Perches
2010-10-26 15:52 ` Dmitry Torokhov
2010-10-26 2:44 ` [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use Joe Perches
2010-10-26 15:50 ` Dmitry Torokhov
2010-10-26 23:25 ` Joe Perches
2010-10-27 0:40 ` Dmitry Torokhov
2010-10-27 0:46 ` Joe Perches
2010-10-27 1:00 ` Dmitry Torokhov
2010-10-27 1:10 ` Joe Perches
2010-10-27 1:28 ` Dmitry Torokhov
2010-10-27 1:35 ` Joe Perches [this message]
2010-10-27 3:00 ` Dmitry Torokhov
2010-10-26 2:44 ` [PATCH 07/10] drivers/media: Removed unnecessary KERN_<level>s from dprintk uses Joe Perches
2010-10-26 2:44 ` [PATCH 08/10] drivers/scsi:mvsas/mv_sas.c: Remove KERN_DEBUG from mv_dprintk use Joe Perches
2010-10-26 2:44 ` [PATCH 09/10] drivers/video/msm/mddi.c: Remove multiple KERN_<level> uses Joe Perches
2010-10-28 17:08 ` Daniel Walker
2010-10-26 2:44 ` [PATCH 10/10] fs/proc/vmcore.c: Use pr_<level> and pr_<fmt> Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288143345.4145.90.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome