From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use
Date: Tue, 26 Oct 2010 18:00:44 -0700 [thread overview]
Message-ID: <BFA186FD-32F7-4E1A-9193-CA1575248B73@gmail.com> (raw)
In-Reply-To: <1288140416.4145.76.camel@Joe-Laptop>
On Oct 26, 2010, at 5:46 PM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2010-10-26 at 17:40 -0700, Dmitry Torokhov wrote:
>>> Mind if I move the time to the front like this?
>>> +#define dbg(format, arg...) \
>>> +do { \
>>> + if (i8042_debug) \
>>> + printk(KERN_DEBUG KBUILD_MODNAME ": [%d]" format), \
>>> + (int)(jiffies - i8042_start_time), ##arg); \
>>> +} while (0)
>> Another option would be to leave '\n' in dbg() and leave most of the
>> callers as is.
>
> That's really error prone though.
>
In what way?
--
Dmitry
next prev parent reply other threads:[~2010-10-27 1:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 2:44 [PATCH 00/10] Remove multiple uses of KERN_<level> Joe Perches
2010-10-26 2:44 ` [PATCH 01/10] arch/x86/kernel/apic/io_apic.c: Typo fix WARNING Joe Perches
2010-10-26 7:48 ` Ingo Molnar
2010-10-26 8:23 ` Joe Perches
2010-10-26 2:44 ` [PATCH 02/10] drivers/atm/eni.c: Remove multiple uses of KERN_<level> Joe Perches
2010-10-26 2:44 ` [PATCH 03/10] drivers/hid/hid-input.c: Remove KERN_DEBUG from dbg_hid use Joe Perches
2010-11-03 14:13 ` Jiri Kosina
2010-10-26 2:44 ` [PATCH 04/10] drivers/infiniband: Remove unnecessary KERN_<level> uses Joe Perches
2010-10-26 11:29 ` Steve Wise
2010-10-26 20:46 ` Roland Dreier
2010-10-26 2:44 ` [PATCH 05/10] drivers/input/mouse/appletouch.c: Remove KERN_DEBUG use from dprintk Joe Perches
2010-10-26 15:52 ` Dmitry Torokhov
2010-10-26 2:44 ` [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use Joe Perches
2010-10-26 15:50 ` Dmitry Torokhov
2010-10-26 23:25 ` Joe Perches
2010-10-27 0:40 ` Dmitry Torokhov
2010-10-27 0:46 ` Joe Perches
2010-10-27 1:00 ` Dmitry Torokhov [this message]
2010-10-27 1:10 ` Joe Perches
2010-10-27 1:28 ` Dmitry Torokhov
2010-10-27 1:35 ` Joe Perches
2010-10-27 3:00 ` Dmitry Torokhov
2010-10-26 2:44 ` [PATCH 07/10] drivers/media: Removed unnecessary KERN_<level>s from dprintk uses Joe Perches
2010-10-26 2:44 ` [PATCH 08/10] drivers/scsi:mvsas/mv_sas.c: Remove KERN_DEBUG from mv_dprintk use Joe Perches
2010-10-26 2:44 ` [PATCH 09/10] drivers/video/msm/mddi.c: Remove multiple KERN_<level> uses Joe Perches
2010-10-28 17:08 ` Daniel Walker
2010-10-26 2:44 ` [PATCH 10/10] fs/proc/vmcore.c: Use pr_<level> and pr_<fmt> Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BFA186FD-32F7-4E1A-9193-CA1575248B73@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=joe@perches.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®