* [PATCH v2] regulator: regulator disable supply fix
@ 2010-11-02 13:55 Mattias Wallin
2010-11-03 10:08 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mattias Wallin @ 2010-11-02 13:55 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown; +Cc: linux-kernel, Mattias Wallin
This patch fixes a disable failure when regulator supply is used.
A while loop in regulator disable checks for supply pointer != NULL
but the pointer is not always updated, resulting in the while loop
running too many times causing a disable failure.
Signed-off-by: Mattias Wallin <mattias.wallin@stericsson.com>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/regulator/core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index f1d10c9..c625633 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1359,6 +1359,7 @@ static int _regulator_disable(struct regulator_dev *rdev,
struct regulator_dev **supply_rdev_ptr)
{
int ret = 0;
+ *supply_rdev_ptr = NULL;
if (WARN(rdev->use_count <= 0,
"unbalanced disables for %s\n",
--
1.6.3.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] regulator: regulator disable supply fix
2010-11-02 13:55 [PATCH v2] regulator: regulator disable supply fix Mattias Wallin
@ 2010-11-03 10:08 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2010-11-03 10:08 UTC (permalink / raw)
To: Mattias Wallin; +Cc: Mark Brown, linux-kernel
On Tue, 2010-11-02 at 14:55 +0100, Mattias Wallin wrote:
> This patch fixes a disable failure when regulator supply is used.
> A while loop in regulator disable checks for supply pointer != NULL
> but the pointer is not always updated, resulting in the while loop
> running too many times causing a disable failure.
>
> Signed-off-by: Mattias Wallin <mattias.wallin@stericsson.com>
> Acked-by: Linus Walleij <linus.walleij@stericsson.com>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/regulator/core.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index f1d10c9..c625633 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1359,6 +1359,7 @@ static int _regulator_disable(struct regulator_dev *rdev,
> struct regulator_dev **supply_rdev_ptr)
> {
> int ret = 0;
> + *supply_rdev_ptr = NULL;
>
> if (WARN(rdev->use_count <= 0,
> "unbalanced disables for %s\n",
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-03 10:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-02 13:55 [PATCH v2] regulator: regulator disable supply fix Mattias Wallin
2010-11-03 10:08 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome