* [PATCH] staging: tidspbridge: overwrite DSP error codes
@ 2010-11-04 0:31 Rene Sapiens
2010-12-06 8:53 ` Ramirez Luna, Omar
0 siblings, 1 reply; 2+ messages in thread
From: Rene Sapiens @ 2010-11-04 0:31 UTC (permalink / raw)
To: greg
Cc: gregkh, nm, felipe.contreras, ernesto, linux-kernel, devel,
linux-omap, Rene Sapiens
When calling the DSP's remote functions, the DSP returns error
codes different from the ones managed by the kernel, the
function's return value is shared with the MPU using a shared
structure. This patch overwrites those error codes by kernel
specifics and deletes unnecessary code.
Signed-off-by: Rene Sapiens <rene.sapiens@ti.com>
---
drivers/staging/tidspbridge/rmgr/disp.c | 44 +++++-------------------------
1 files changed, 8 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr/disp.c b/drivers/staging/tidspbridge/rmgr/disp.c
index b7ce435..560069a 100644
--- a/drivers/staging/tidspbridge/rmgr/disp.c
+++ b/drivers/staging/tidspbridge/rmgr/disp.c
@@ -460,17 +460,6 @@ int disp_node_create(struct disp_object *disp_obj,
DBC_ASSERT(ul_bytes < (RMS_COMMANDBUFSIZE * sizeof(rms_word)));
status = send_message(disp_obj, node_get_timeout(hnode),
ul_bytes, node_env);
- if (status >= 0) {
- /*
- * Message successfully received from RMS.
- * Return the status of the Node's create function
- * on the DSP-side
- */
- status = (((rms_word *) (disp_obj->pbuf))[0]);
- if (status < 0)
- dev_dbg(bridge, "%s: DSP-side failed: 0x%x\n",
- __func__, status);
- }
}
func_end:
return status;
@@ -513,18 +502,6 @@ int disp_node_delete(struct disp_object *disp_obj,
status = send_message(disp_obj, node_get_timeout(hnode),
sizeof(struct rms_command),
&dw_arg);
- if (status >= 0) {
- /*
- * Message successfully received from RMS.
- * Return the status of the Node's delete
- * function on the DSP-side
- */
- status = (((rms_word *) (disp_obj->pbuf))[0]);
- if (status < 0)
- dev_dbg(bridge, "%s: DSP-side failed: "
- "0x%x\n", __func__, status);
- }
-
}
}
return status;
@@ -566,18 +543,6 @@ int disp_node_run(struct disp_object *disp_obj,
status = send_message(disp_obj, node_get_timeout(hnode),
sizeof(struct rms_command),
&dw_arg);
- if (status >= 0) {
- /*
- * Message successfully received from RMS.
- * Return the status of the Node's execute
- * function on the DSP-side
- */
- status = (((rms_word *) (disp_obj->pbuf))[0]);
- if (status < 0)
- dev_dbg(bridge, "%s: DSP-side failed: "
- "0x%x\n", __func__, status);
- }
-
}
}
@@ -739,7 +704,14 @@ static int send_message(struct disp_object *disp_obj, u32 timeout,
} else {
if (CHNL_IS_IO_COMPLETE(chnl_ioc_obj)) {
DBC_ASSERT(chnl_ioc_obj.pbuf == pbuf);
- status = (*((rms_word *) chnl_ioc_obj.pbuf));
+ if (*((int *)chnl_ioc_obj.pbuf) < 0) {
+ /* Translate DSP's to kernel error */
+ status = -EREMOTEIO;
+ dev_dbg(bridge, "%s: DSP-side failed:"
+ " DSP errcode = 0x%x, Kernel "
+ "errcode = %d\n", __func__,
+ *(int *)pbuf, status);
+ }
*pdw_arg =
(((rms_word *) (chnl_ioc_obj.pbuf))[1]);
} else {
--
1.6.3.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: tidspbridge: overwrite DSP error codes
2010-11-04 0:31 [PATCH] staging: tidspbridge: overwrite DSP error codes Rene Sapiens
@ 2010-12-06 8:53 ` Ramirez Luna, Omar
0 siblings, 0 replies; 2+ messages in thread
From: Ramirez Luna, Omar @ 2010-12-06 8:53 UTC (permalink / raw)
To: Rene Sapiens
Cc: greg, gregkh, nm, felipe.contreras, ernesto, linux-kernel, devel,
linux-omap
On Wed, Nov 3, 2010 at 7:31 PM, Rene Sapiens <rene.sapiens@ti.com> wrote:
> When calling the DSP's remote functions, the DSP returns error
> codes different from the ones managed by the kernel, the
> function's return value is shared with the MPU using a shared
> structure. This patch overwrites those error codes by kernel
> specifics and deletes unnecessary code.
>
> Signed-off-by: Rene Sapiens <rene.sapiens@ti.com>
> ---
> drivers/staging/tidspbridge/rmgr/disp.c | 44 +++++-------------------------
> 1 files changed, 8 insertions(+), 36 deletions(-)
Pushed to dspbridge.
Regards,
Omar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-06 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-04 0:31 [PATCH] staging: tidspbridge: overwrite DSP error codes Rene Sapiens
2010-12-06 8:53 ` Ramirez Luna, Omar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®