From: "Søren Sandmann Pedersen" <ssp@redhat.com>
To: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] x86: Eliminate bp argument from the stack tracing routines
Date: Fri, 5 Nov 2010 07:14:33 -0400 [thread overview]
Message-ID: <1288955674-2744-1-git-send-email-ssp@redhat.com> (raw)
In-Reply-To: <ye8ljj3mlj5.fsf@camel16.daimi.au.dk>
Hi,
This is a resurrection of an old patch that I sent about a year ago:
http://lkml.org/lkml/2009/10/22/192
At the time, I thought the patch broke perf callchains on 64 bit, but
it turns out that those are broken even without this patch.
I don't know why that is, but I now think the patch is correct and to
blame.
(FWIW, this
diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c
index 461a85d..d977d26 100644
--- a/arch/x86/kernel/cpu/perf_event.c
+++ b/arch/x86/kernel/cpu/perf_event.c
@@ -1653,7 +1653,7 @@ static const struct stacktrace_ops backtrace_ops = {
.warning_symbol = backtrace_warning_symbol,
.stack = backtrace_stack,
.address = backtrace_address,
- .walk_stack = print_context_stack_bp,
+ .walk_stack = print_context_stack,
};
makes it produce correct kernel callchains. And yes, I did compile the
kernel with CONFIG_FRAME_POINTER).
Soren
next prev parent reply other threads:[~2010-11-05 11:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ye8vdi7mluz.fsf@camel16.daimi.au.dk>
2009-10-22 16:34 ` [PATCH 2/2 -tip] perf: Don't generate events for the idle task when exclude_idle is set Soeren Sandmann
2009-10-22 16:38 ` [PATCH] x86: Get bp from the IRQ regs instead of directly from the CPU Soeren Sandmann
2009-10-23 10:50 ` Ingo Molnar
2009-10-29 12:46 ` Soeren Sandmann
2010-11-05 11:14 ` Søren Sandmann Pedersen [this message]
2010-11-07 21:24 ` [PATCH 0/1] x86: Eliminate bp argument from the stack tracing routines Frederic Weisbecker
2010-11-08 11:38 ` Soeren Sandmann
2010-11-18 15:32 ` Frederic Weisbecker
2010-11-05 11:14 ` [PATCH] " Søren Sandmann Pedersen
2009-10-23 7:35 ` [PATCH 1/2 -tip] perf: Keep track of remaining time when enabling/disabling swevent hrtimers Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288955674-2744-1-git-send-email-ssp@redhat.com \
--to=ssp@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome