mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Li,Rongqing" <lirongqing@baidu.com>
To: Sean Christopherson <seanjc@google.com>,
	"Michael Kelley (LINUX)" <mikelley@microsoft.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>
Cc: KY Srinivasan <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>,
	Dexuan Cui <decui@microsoft.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] clockevents/drivers/i8253: Do not zero timer counter in shutdown
Date: Fri, 24 Feb 2023 09:45:39 +0000	[thread overview]
Message-ID: <12889cfa141f4a06958ead0ab7f0a375@baidu.com> (raw)
In-Reply-To: <Y+O56OXIuARBhsg2@google.com>

> > > Hyper-V and KVM follow the spec, the issue that 35b69a42
> > > "(clockevents/drivers/
> > > i8253: Add support for PIT shutdown quirk") fixed is in i8253
> > > drivers, not Hyper-v, so delete the zero timer counter register in
> > > shutdown, and delete PIT shutdown quirk for Hyper-v
> >
> > From the standpoint of Hyper-V, I'm good with this change.  But
> > there's a risk that old hardware might not be compliant with the spec,
> > and needs the zero'ing for some reason. The experts in the x86 space
> > will be in the best position to assess the risk.
> 
> Yep, my feeling exactly.  My input is purely from reading those crusty old specs.

Hi Thomas:

Could you give some suggestion about this patch?

Thanks

-Li

  reply	other threads:[~2023-02-24 10:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07  1:14 lirongqing
2023-02-08  1:04 ` Michael Kelley (LINUX)
2023-02-08 15:04   ` Sean Christopherson
2023-02-24  9:45     ` Li,Rongqing [this message]
     [not found]     ` <3b8496c071214bda9e5ecfa048f18ab9@baidu.com>
2023-04-13  1:28       ` Wei Liu
     [not found]       ` <1311175816673.202304.ZDdawTGHoa/UH20U@liuwe-devbox-debian-v2>
2023-04-14  5:17         ` Li,Rongqing
2024-08-01  9:00   ` David Woodhouse
2024-08-01 15:22     ` David Woodhouse
2024-08-01 21:07       ` Thomas Gleixner
2024-08-01 21:10         ` David Woodhouse
2024-08-01 14:21 ` Thomas Gleixner
2024-08-01 16:14   ` Michael Kelley
2024-08-01 18:54     ` Thomas Gleixner
2024-08-02  8:21       ` David Woodhouse
2024-08-02 14:55         ` Sean Christopherson
2024-08-02 15:04           ` David Woodhouse
2024-08-12 23:59             ` Sean Christopherson
2024-08-13  6:39               ` David Woodhouse
2024-08-01 17:49   ` David Woodhouse
2024-08-01 18:25     ` David Woodhouse
2024-08-01 18:57       ` Thomas Gleixner
2024-08-02  8:07         ` David Woodhouse
2024-08-02 10:49           ` Thomas Gleixner
2024-08-02 11:04             ` David Woodhouse
2024-08-02 13:27               ` Thomas Gleixner
2024-08-02 13:46                 ` David Woodhouse
2024-08-01 19:06     ` Thomas Gleixner
2024-08-01 19:21       ` David Woodhouse
2024-08-01 20:00         ` Thomas Gleixner
2024-08-01 20:49           ` David Woodhouse
2024-08-01 21:22             ` Thomas Gleixner
2024-08-01 21:31               ` David Woodhouse
2024-08-02  9:55                 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12889cfa141f4a06958ead0ab7f0a375@baidu.com \
    --to=lirongqing@baidu.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=mingo@redhat.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®