From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <guenter.roeck@ericsson.com>,
Simon Guinot <sguinot@lacie.com>,
lm-sensors@lm-sensors.org
Subject: [PATCH] hwmon: (gpio-fan) Fix fan_ctrl_init error path
Date: Tue, 09 Nov 2010 13:18:39 +0800 [thread overview]
Message-ID: <1289279919.14461.7.camel@mola> (raw)
Remove sysfs entries before return -ENODEV.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/hwmon/gpio-fan.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c
index aa701a1..d2e66b4 100644
--- a/drivers/hwmon/gpio-fan.c
+++ b/drivers/hwmon/gpio-fan.c
@@ -388,11 +388,13 @@ static int fan_ctrl_init(struct gpio_fan_data *fan_data,
fan_data->speed_index = get_fan_speed_index(fan_data);
if (fan_data->speed_index < 0) {
err = -ENODEV;
- goto err_free_gpio;
+ goto err_remove_sysfs;
}
return 0;
+err_remove_sysfs:
+ sysfs_remove_group(&pdev->dev.kobj, &gpio_fan_ctrl_group);
err_free_gpio:
for (i = i - 1; i >= 0; i--)
gpio_free(ctrl[i]);
--
1.7.2
next reply other threads:[~2010-11-09 5:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 5:18 Axel Lin [this message]
2010-11-09 7:59 ` Jean Delvare
2010-11-09 8:01 ` Jean Delvare
2010-11-09 8:22 ` Axel Lin
2010-11-09 9:14 ` Jean Delvare
2010-11-09 9:25 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289279919.14461.7.camel@mola \
--to=axel.lin@gmail.com \
--cc=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=sguinot@lacie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome