mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Rosenberg <drosenberg@vsecurity.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, security@kernel.org,
	stable@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] Restrict unprivileged access to kernel syslog
Date: Tue, 09 Nov 2010 07:11:12 -0500	[thread overview]
Message-ID: <1289304672.6287.132.camel@dan> (raw)
In-Reply-To: <20101109112350.GA29800@elte.hu>


> 
> The initialization to zero is implicit, no need to write it out.
> 

I'll resend after the first round of comments.

> Also, it would also be useful to have a CONFIG_SECURITY_RESTRICT_DMESG=y option 
> introduced by your patch as well, which flag allows a distro or user to disable 
> unprivileged syslog reading via the kernel config.

Are you suggesting having the existence of the sysctl depend on
CONFIG_SECURITY_RESTRICT_DMESG, or having a choice between a sysctl
(when config is disabled) and having restrictions always on (when config
is enabled)?

-Dan


  reply	other threads:[~2010-11-09 12:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09  3:28 Dan Rosenberg
2010-11-09  5:34 ` Kees Cook
2010-11-09  5:39   ` [Security] " Eugene Teo
2010-11-09 11:23 ` Ingo Molnar
2010-11-09 12:11   ` Dan Rosenberg [this message]
2010-11-09 12:27     ` Arjan van de Ven
2010-11-09 14:20       ` Ingo Molnar
2010-11-09 12:06 ` Alan Cox
2010-11-17 10:03   ` Pavel Machek
2010-11-09 14:25 Dan Rosenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289304672.6287.132.camel@dan \
    --to=drosenberg@vsecurity.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=security@kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome