mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dan Rosenberg <drosenberg@vsecurity.com>
Cc: linux-kernel@vger.kernel.org, security@kernel.org, stable@kernel.org
Subject: Re: [PATCH] Restrict unprivileged access to kernel syslog
Date: Tue, 9 Nov 2010 12:06:49 +0000	[thread overview]
Message-ID: <20101109120649.62b487e8@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1289273338.6287.128.camel@dan>

On Mon, 08 Nov 2010 22:28:58 -0500
Dan Rosenberg <drosenberg@vsecurity.com> wrote:

> The kernel syslog contains debugging information that is often useful
> during exploitation of other vulnerabilities, such as kernel heap
> addresses.  Rather than futilely attempt to sanitize hundreds (or
> thousands) of printk statements and simultaneously cripple useful
> debugging functionality, it is far simpler to create an option that
> prevents unprivileged users from reading the syslog.

Except for anything that appears on the screen - which is remotely
readable via the screen access APIs. Looks sane to me (pointless but
sane) and the checks match the ones needed to redirect the console so you
need CAP_SYS_ADMIN either way.

  parent reply	other threads:[~2010-11-09 12:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09  3:28 Dan Rosenberg
2010-11-09  5:34 ` Kees Cook
2010-11-09  5:39   ` [Security] " Eugene Teo
2010-11-09 11:23 ` Ingo Molnar
2010-11-09 12:11   ` Dan Rosenberg
2010-11-09 12:27     ` Arjan van de Ven
2010-11-09 14:20       ` Ingo Molnar
2010-11-09 12:06 ` Alan Cox [this message]
2010-11-17 10:03   ` Pavel Machek
2010-11-09 14:25 Dan Rosenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101109120649.62b487e8@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=drosenberg@vsecurity.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®