From: Will Deacon <will.deacon@arm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>,
ralf@linux-mips.org, fweisbec@gmail.com,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
wuzhangjin@gmail.com, paulus@samba.org, mingo@elte.hu,
acme@redhat.com
Subject: Re: [PATCH 3/5] MIPS/Perf-events: Check event state in validate_event()
Date: Fri, 19 Nov 2010 12:03:27 +0000 [thread overview]
Message-ID: <1290168207.8175.6.camel@e102144-lin.cambridge.arm.com> (raw)
In-Reply-To: <1290166051.2109.1539.camel@laptop>
On Fri, 2010-11-19 at 11:27 +0000, Peter Zijlstra wrote:
> > So this is the opposite of what we're doing on ARM. Our
> > approach is to ignore events that are OFF (or in the ERROR
> > state) or that belong to a different PMU. We do this by
> > allowing them to *pass* validation (i.e. by returning 1 above).
> > This means that we won't unconditionally fail a mixed event group.
> >
> > x86 does something similar in the collect_events function.
>
> Right, note that the generic code only allows mixing with software
> events, so simply accepting them is ok as software events give the
> guarantee they're always schedulable.
>
>
Ok. Initially it was software events that I had in mind, but does
this constraint prevent you from grouping CPU events with events
for other PMUs within the system? For external L2 cache controllers
with their own PMUs, it would be desirable to group some L2 events
with L1 events on a different PMU.
If each PMU can validate its own events and ignore others then it
sounds like it should be straightforward...
Will
next prev parent reply other threads:[~2010-11-19 12:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 6:56 [PATCH 0/5] MIPS/Perf-events: Sync with mainline upper layer Deng-Cheng Zhu
2010-11-18 6:56 ` [PATCH 1/5] MIPS/Perf-events: Work with irq_work Deng-Cheng Zhu
2010-11-25 6:58 ` Peter Zijlstra
2010-11-18 6:56 ` [PATCH 2/5] MIPS/Perf-events: Work with the new PMU interface Deng-Cheng Zhu
2010-11-25 7:01 ` Peter Zijlstra
2010-11-18 6:56 ` [PATCH 3/5] MIPS/Perf-events: Check event state in validate_event() Deng-Cheng Zhu
2010-11-19 9:43 ` Will Deacon
2010-11-19 11:27 ` Peter Zijlstra
2010-11-19 12:03 ` Will Deacon [this message]
2010-11-19 12:09 ` Peter Zijlstra
2010-11-19 11:30 ` Deng-Cheng Zhu
2010-11-19 12:05 ` Will Deacon
2010-11-18 6:56 ` [PATCH 4/5] MIPS/Perf-events: Work with the new callchain interface Deng-Cheng Zhu
2010-11-19 14:34 ` Frederic Weisbecker
2010-11-23 7:06 ` Deng-Cheng Zhu
2010-11-18 6:56 ` [PATCH 5/5] MIPS/Perf-events: Use unsigned delta for right shift in event update Deng-Cheng Zhu
2010-11-18 9:27 ` Will Deacon
2010-11-19 7:16 ` Deng-Cheng Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290168207.8175.6.camel@e102144-lin.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dengcheng.zhu@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®