From: Will Deacon <will.deacon@arm.com>
To: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: ralf@linux-mips.org, a.p.zijlstra@chello.nl, fweisbec@gmail.com,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
wuzhangjin@gmail.com, paulus@samba.org, mingo@elte.hu,
acme@redhat.com
Subject: Re: [PATCH 3/5] MIPS/Perf-events: Check event state in validate_event()
Date: Fri, 19 Nov 2010 12:05:05 +0000 [thread overview]
Message-ID: <1290168306.8175.8.camel@e102144-lin.cambridge.arm.com> (raw)
In-Reply-To: <AANLkTikdLqo0-jkLkY-jGxurKMnmv+gb0VWWDZu6TOwd@mail.gmail.com>
On Fri, 2010-11-19 at 11:30 +0000, Deng-Cheng Zhu wrote:
> Ah, I see. Thanks for your explanation.
>
> But by doing this, I think we need to modify validate_group() as well.
> Consider a group which has all its events either not for this PMU or in
> OFF/Error state. Then the last validate_event() in validate_group() does
> not work. Right? So, how about the following:
[...]
If none of the events are for this PMU, then our validate_group()
won't be called. If all the events are OFF/ERROR then I don't see
what's wrong with passing the validation.
Will
next prev parent reply other threads:[~2010-11-19 12:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 6:56 [PATCH 0/5] MIPS/Perf-events: Sync with mainline upper layer Deng-Cheng Zhu
2010-11-18 6:56 ` [PATCH 1/5] MIPS/Perf-events: Work with irq_work Deng-Cheng Zhu
2010-11-25 6:58 ` Peter Zijlstra
2010-11-18 6:56 ` [PATCH 2/5] MIPS/Perf-events: Work with the new PMU interface Deng-Cheng Zhu
2010-11-25 7:01 ` Peter Zijlstra
2010-11-18 6:56 ` [PATCH 3/5] MIPS/Perf-events: Check event state in validate_event() Deng-Cheng Zhu
2010-11-19 9:43 ` Will Deacon
2010-11-19 11:27 ` Peter Zijlstra
2010-11-19 12:03 ` Will Deacon
2010-11-19 12:09 ` Peter Zijlstra
2010-11-19 11:30 ` Deng-Cheng Zhu
2010-11-19 12:05 ` Will Deacon [this message]
2010-11-18 6:56 ` [PATCH 4/5] MIPS/Perf-events: Work with the new callchain interface Deng-Cheng Zhu
2010-11-19 14:34 ` Frederic Weisbecker
2010-11-23 7:06 ` Deng-Cheng Zhu
2010-11-18 6:56 ` [PATCH 5/5] MIPS/Perf-events: Use unsigned delta for right shift in event update Deng-Cheng Zhu
2010-11-18 9:27 ` Will Deacon
2010-11-19 7:16 ` Deng-Cheng Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290168306.8175.8.camel@e102144-lin.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dengcheng.zhu@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®