* [PATCH trace-cmd] kvm: don't warn on new fields
@ 2010-11-29 17:25 Avi Kivity
2010-11-29 23:33 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Avi Kivity @ 2010-11-29 17:25 UTC (permalink / raw)
To: Steven Rostedt; +Cc: kvm, linux-kernel, linux-trace-users
The kvm plugin understands a few new fields; don't warn if they are missing,
as expected on older kernels.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
plugin_kvm.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/plugin_kvm.c b/plugin_kvm.c
index c1cb2e4..8115235 100644
--- a/plugin_kvm.c
+++ b/plugin_kvm.c
@@ -249,15 +249,15 @@ static int kvm_exit_handler(struct trace_seq *s, struct record *record,
if (pevent_get_field_val(s, event, "exit_reason", record, &val, 1) < 0)
return -1;
- if (pevent_get_field_val(s, event, "isa", record, &isa, 1) < 0)
+ if (pevent_get_field_val(s, event, "isa", record, &isa, 0) < 0)
isa = 1;
trace_seq_printf(s, "reason %s", find_exit_reason(isa, val));
pevent_print_num_field(s, " rip 0x%lx", event, "guest_rip", record, 1);
- if (pevent_get_field_val(s, event, "info1", record, &info1, 1) >= 0
- && pevent_get_field_val(s, event, "info2", record, &info2, 1) >= 0)
+ if (pevent_get_field_val(s, event, "info1", record, &info1, 0) >= 0
+ && pevent_get_field_val(s, event, "info2", record, &info2, 0) >= 0)
trace_seq_printf(s, " info %llx %llx\n", info1, info2);
return 0;
--
1.7.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH trace-cmd] kvm: don't warn on new fields
2010-11-29 17:25 [PATCH trace-cmd] kvm: don't warn on new fields Avi Kivity
@ 2010-11-29 23:33 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2010-11-29 23:33 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm, linux-kernel, linux-trace-users
On Mon, 2010-11-29 at 19:25 +0200, Avi Kivity wrote:
> The kvm plugin understands a few new fields; don't warn if they are missing,
> as expected on older kernels.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
> plugin_kvm.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Applied, Thanks Avi!
-- Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-29 23:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-29 17:25 [PATCH trace-cmd] kvm: don't warn on new fields Avi Kivity
2010-11-29 23:33 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®