From: Mikko Perttunen <mperttunen@nvidia.com>
To: linux-kernel@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors
Date: Wed, 17 Sep 2025 11:05:49 +0900 [thread overview]
Message-ID: <12921334.O9o76ZdvQC@senjougahara> (raw)
In-Reply-To: <20250813190657.3628-2-wsa+renesas@sang-engineering.com>
On Thursday, August 14, 2025 4:06 AM Wolfram Sang wrote:
> The watchdog core will handle error messages already.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/clocksource/timer-tegra186.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/timer-tegra186.c
> index e5394f98a02e..b40d7ed37936 100644
> --- a/drivers/clocksource/timer-tegra186.c
> +++ b/drivers/clocksource/timer-tegra186.c
> @@ -328,16 +328,12 @@ static struct tegra186_wdt *tegra186_wdt_create(struct tegra186_timer *tegra,
> wdt->base.parent = tegra->dev;
>
> err = watchdog_init_timeout(&wdt->base, 5, tegra->dev);
> - if (err < 0) {
> - dev_err(tegra->dev, "failed to initialize timeout: %d\n", err);
> + if (err < 0)
> return ERR_PTR(err);
> - }
>
> err = devm_watchdog_register_device(tegra->dev, &wdt->base);
> - if (err < 0) {
> - dev_err(tegra->dev, "failed to register WDT: %d\n", err);
> + if (err < 0)
> return ERR_PTR(err);
> - }
>
> return wdt;
> }
>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
next prev parent reply other threads:[~2025-09-17 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 19:06 Wolfram Sang
2025-09-17 2:05 ` Mikko Perttunen [this message]
2025-09-17 8:24 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12921334.O9o76ZdvQC@senjougahara \
--to=mperttunen@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®