* [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors
@ 2025-08-13 19:06 Wolfram Sang
2025-09-17 2:05 ` Mikko Perttunen
2025-09-17 8:24 ` Daniel Lezcano
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2025-08-13 19:06 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Daniel Lezcano, Thomas Gleixner, Thierry Reding,
Jonathan Hunter, linux-tegra
The watchdog core will handle error messages already.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/clocksource/timer-tegra186.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/timer-tegra186.c
index e5394f98a02e..b40d7ed37936 100644
--- a/drivers/clocksource/timer-tegra186.c
+++ b/drivers/clocksource/timer-tegra186.c
@@ -328,16 +328,12 @@ static struct tegra186_wdt *tegra186_wdt_create(struct tegra186_timer *tegra,
wdt->base.parent = tegra->dev;
err = watchdog_init_timeout(&wdt->base, 5, tegra->dev);
- if (err < 0) {
- dev_err(tegra->dev, "failed to initialize timeout: %d\n", err);
+ if (err < 0)
return ERR_PTR(err);
- }
err = devm_watchdog_register_device(tegra->dev, &wdt->base);
- if (err < 0) {
- dev_err(tegra->dev, "failed to register WDT: %d\n", err);
+ if (err < 0)
return ERR_PTR(err);
- }
return wdt;
}
--
2.47.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors
2025-08-13 19:06 [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors Wolfram Sang
@ 2025-09-17 2:05 ` Mikko Perttunen
2025-09-17 8:24 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Mikko Perttunen @ 2025-09-17 2:05 UTC (permalink / raw)
To: linux-kernel, Wolfram Sang
Cc: Wolfram Sang, Daniel Lezcano, Thomas Gleixner, Thierry Reding,
Jonathan Hunter, linux-tegra
On Thursday, August 14, 2025 4:06 AM Wolfram Sang wrote:
> The watchdog core will handle error messages already.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/clocksource/timer-tegra186.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/timer-tegra186.c
> index e5394f98a02e..b40d7ed37936 100644
> --- a/drivers/clocksource/timer-tegra186.c
> +++ b/drivers/clocksource/timer-tegra186.c
> @@ -328,16 +328,12 @@ static struct tegra186_wdt *tegra186_wdt_create(struct tegra186_timer *tegra,
> wdt->base.parent = tegra->dev;
>
> err = watchdog_init_timeout(&wdt->base, 5, tegra->dev);
> - if (err < 0) {
> - dev_err(tegra->dev, "failed to initialize timeout: %d\n", err);
> + if (err < 0)
> return ERR_PTR(err);
> - }
>
> err = devm_watchdog_register_device(tegra->dev, &wdt->base);
> - if (err < 0) {
> - dev_err(tegra->dev, "failed to register WDT: %d\n", err);
> + if (err < 0)
> return ERR_PTR(err);
> - }
>
> return wdt;
> }
>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors
2025-08-13 19:06 [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors Wolfram Sang
2025-09-17 2:05 ` Mikko Perttunen
@ 2025-09-17 8:24 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2025-09-17 8:24 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel
Cc: Thomas Gleixner, Thierry Reding, Jonathan Hunter, linux-tegra
On 13/08/2025 21:06, Wolfram Sang wrote:
> The watchdog core will handle error messages already.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-17 8:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-13 19:06 [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors Wolfram Sang
2025-09-17 2:05 ` Mikko Perttunen
2025-09-17 8:24 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®