[GIT PULL] notification bug fixes

[GIT PULL] notification bug fixes

[Eric Paris]

The notable fixes in this pull request include a potential deadlock when
fanotify listeners exit, an unpriv user kernel memory DoS in inotify,
and an API (although not ABI) change in fanotify's userspace message to
support expansion in the next release.

-Eric

--------
The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:

  Linux 2.6.37-rc4 (2010-11-29 20:42:04 -0800)

are available in the git repository at:
  git://git.infradead.org/users/eparis/notify.git for-linus

Alexey Zaytsev (1):
      fanotify: split version into version and metadata_len

Eric Paris (5):
      fanotify: deny permissions when no event was sent
      fanotify: remove packed from access response message
      inotify: stop kernel memory leak on file creation failure
      fanotify: do not leak user reference on allocation failure
      fanotify: fill in the metadata_len field on struct fanotify_event_metadata

Lino Sanfilippo (6):
      fanotify: if set by user unset FMODE_NONOTIFY before fsnotify_perm() is called
      fanotify: correct broken ref counting in case adding a mark failed
      fanotify: Dont allow a mask of 0 if setting or removing a mark
      fanotify: on group destroy allow all waiters to bypass permission check
      fanotify: Introduce FAN_NOFD
      fanotify: Dont try to open a file descriptor for the overflow event

 fs/namei.c                         |    3 +
 fs/notify/fanotify/fanotify.c      |    6 ++-
 fs/notify/fanotify/fanotify_user.c |   81 ++++++++++++++++++++++-------------
 fs/notify/inotify/inotify_user.c   |    1 +
 include/linux/fanotify.h           |   10 +++-
 include/linux/fsnotify.h           |    3 -
 include/linux/fsnotify_backend.h   |    2 +-
 7 files changed, 68 insertions(+), 38 deletions(-)

Re: [GIT PULL] notification bug fixes

[Tvrtko Ursulin]

Hi,

On Wednesday 15 Dec 2010 19:17:27 Eric Paris wrote:
> The notable fixes in this pull request include a potential deadlock when
> fanotify listeners exit, an unpriv user kernel memory DoS in inotify,
> and an API (although not ABI) change in fanotify's userspace message to
> support expansion in the next release.

Would you consider pushing e3366737eeee6c3c482af3758c6dcb65eccfa62d and
dependencies (ba611b1c12a230785c25a7b3a5ea948fda8cc137,
http://marc.info/?l=linux-kernel&m=129200322526558&w=2)? It would make it
easier for userspace if first published kernel already had
FAN_READONLY_FALLBACK.

Which also reminds me, would a way to explicitly get the protocol version be
useful?

Tvrtko

Sophos Limited, The Pentagon, Abingdon Science Park, Abingdon, OX14 3YP, United Kingdom.
Company Reg No 2096520. VAT Reg No GB 991 2418 08.