From: Tejun Heo <tj@kernel.org>
To: oleg@redhat.com, roland@redhat.com, linux-kernel@vger.kernel.org,
rjw@sisk.pl, jan.kratochvil@redhat.com
Cc: Tejun Heo <tj@kernel.org>
Subject: [PATCH 3/4] signal: remove superflous try_to_freeze() loop in do_signal_stop()
Date: Wed, 22 Dec 2010 12:13:17 +0100 [thread overview]
Message-ID: <1293016398-18001-4-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1293016398-18001-1-git-send-email-tj@kernel.org>
do_signal_stop() is used only by get_signal_to_deliver() and after a
successful signal stop, it always calls try_to_freeze(), so the
try_to_freeze() loop around schedule() in do_signal_stop() is
superflous and confusing. Remove it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>
---
kernel/signal.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index fe004b5..0a6816a 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1781,9 +1781,7 @@ static int do_signal_stop(int signr)
}
/* Now we don't run again until woken by SIGCONT or SIGKILL */
- do {
- schedule();
- } while (try_to_freeze());
+ schedule();
tracehook_finish_jctl();
current->exit_code = 0;
--
1.7.1
next prev parent reply other threads:[~2010-12-22 11:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 11:13 [PATCHSET] ptrace,signal: cleanups and fixes Tejun Heo
2010-12-22 11:13 ` [PATCH 1/4] signal: fix SIGCONT notification code Tejun Heo
2011-01-12 20:41 ` Jan Kratochvil
2011-01-13 11:27 ` Tejun Heo
2011-01-13 14:40 ` Oleg Nesterov
2010-12-22 11:13 ` [PATCH 2/4] ptrace: remove the extra wake_up_process() from ptrace_detach() Tejun Heo
2011-01-17 22:13 ` Roland McGrath
2011-01-27 13:34 ` Tejun Heo
2011-01-28 7:02 ` Roland McGrath
2011-01-28 10:59 ` Tejun Heo
2010-12-22 11:13 ` Tejun Heo [this message]
2011-01-17 22:10 ` [PATCH 3/4] signal: remove superflous try_to_freeze() loop in do_signal_stop() Roland McGrath
2010-12-22 11:13 ` [PATCH 4/4] ptrace: kill tracehook_notify_jctl() Tejun Heo
2011-01-17 22:14 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293016398-18001-4-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=jan.kratochvil@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rjw@sisk.pl \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome