mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shaohua Li <shaohua.li@intel.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>
Subject: Re: [patch 2/3] add new macros to make percpu readmostly section correctly align
Date: Thu, 23 Dec 2010 10:38:34 +0800	[thread overview]
Message-ID: <1293071914.10593.10.camel@sli10-conroe> (raw)
In-Reply-To: <4D0F7C5A.1060107@gmail.com>

On Mon, 2010-12-20 at 23:55 +0800, Tejun Heo wrote:
> Hello,
> 
> On 12/20/2010 02:28 AM, Shaohua Li wrote:
> >> Not being able to cross build every arch is okay but you at least need
> >> to make an effort to make things easily applicable to other archs and
> >> avoid adding subtle ugliness like the above.  Please at least try to
> >> look at other arch codes and see how things can be made to work across
> >> different archs.  Setting up cross compilers for the major archs, for
> >> example, sparc, power and ia64 isn't that difficult either.
> >
> > This still needs I fix every arch, for example, as Sam pointed out,
> > spark build will fail. I really have the bandwidth and capability to do
> > this. Increment changes are always preferred. My original patch is
> > trying to follow increment changes way.
> 
> Yeah, well, in my experience, those approaches usually just end up
> piling partial conversions on top of different set of partial
> conversions.  It's not like we're talking about a major arch dependent
> feature it's just a matter of looking through different arch codes,
> maybe test building some, pushing things to linux-next and dealing
> with fallouts if there is any.  I'll try to do it myself.
Thanks for doing it and sorry I didn't do it.
The first patch in the series isn't related to this issue, please
consider merge it.

Thanks,
Shaohua


  reply	other threads:[~2010-12-23  2:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02  2:02 Shaohua Li
2010-12-10 15:14 ` Tejun Heo
2010-12-13  0:41   ` Shaohua Li
2010-12-13  9:47     ` Tejun Heo
2010-12-14  1:08       ` Shaohua Li
2010-12-14  9:58         ` Tejun Heo
2010-12-15  1:57           ` Shaohua Li
2010-12-15 14:08             ` Tejun Heo
2010-12-15 14:49               ` Tejun Heo
2010-12-16  0:55                 ` Shaohua Li
2010-12-16  0:53               ` Shaohua Li
2010-12-16  5:46                 ` Sam Ravnborg
2010-12-16  5:56                   ` Shaohua Li
2010-12-16  9:50                     ` Tejun Heo
2010-12-20  1:28                       ` Shaohua Li
2010-12-20 15:55                         ` Tejun Heo
2010-12-23  2:38                           ` Shaohua Li [this message]
2010-12-27 12:14                             ` Tejun Heo
2010-12-28  0:26                               ` Shaohua Li
2010-12-28 11:13                                 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293071914.10593.10.camel@sli10-conroe \
    --to=shaohua.li@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=eric.dumazet@gmail.com \
    --cc=hpa@zytor.com \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®