mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Shaohua Li <shaohua.li@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>
Subject: Re: [patch 2/3] add new macros to make percpu readmostly section correctly align
Date: Tue, 28 Dec 2010 12:13:32 +0100	[thread overview]
Message-ID: <20101228111332.GE488@htj.dyndns.org> (raw)
In-Reply-To: <1293496017.10593.26.camel@sli10-conroe>

Hello,

On Tue, Dec 28, 2010 at 08:26:57AM +0800, Shaohua Li wrote:
> Subject: make readmostly section correctly align
> 
> readmostly section should end at cache line aligned address, otherwise the last
> several data might share cachline with other data and make the readmostly data
> still have cache bounce.
> For example, in ia64, secpath_cachep is the last readmostly data, and it shares
> cacheline with init_uts_ns.
> a000000100e80480 d secpath_cachep
> a000000100e80488 D init_uts_ns
> 
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>

Yeap, this looks good to me.

 Acked-by: Tejun Heo <tj@kernel.org>

I can route this through percpu tree but think -mm is the better fit.
Andrew, can you please take this one?

Thank you.

-- 
tejun

      reply	other threads:[~2010-12-28 11:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02  2:02 Shaohua Li
2010-12-10 15:14 ` Tejun Heo
2010-12-13  0:41   ` Shaohua Li
2010-12-13  9:47     ` Tejun Heo
2010-12-14  1:08       ` Shaohua Li
2010-12-14  9:58         ` Tejun Heo
2010-12-15  1:57           ` Shaohua Li
2010-12-15 14:08             ` Tejun Heo
2010-12-15 14:49               ` Tejun Heo
2010-12-16  0:55                 ` Shaohua Li
2010-12-16  0:53               ` Shaohua Li
2010-12-16  5:46                 ` Sam Ravnborg
2010-12-16  5:56                   ` Shaohua Li
2010-12-16  9:50                     ` Tejun Heo
2010-12-20  1:28                       ` Shaohua Li
2010-12-20 15:55                         ` Tejun Heo
2010-12-23  2:38                           ` Shaohua Li
2010-12-27 12:14                             ` Tejun Heo
2010-12-28  0:26                               ` Shaohua Li
2010-12-28 11:13                                 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101228111332.GE488@htj.dyndns.org \
    --to=htejun@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=eric.dumazet@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome