* [GIT PULL] perf callchain fixlet
@ 2011-01-03 17:45 Frederic Weisbecker
0 siblings, 0 replies; only message in thread
From: Frederic Weisbecker @ 2011-01-03 17:45 UTC (permalink / raw)
To: Ingo Molnar
Cc: LKML, Frederic Weisbecker, Nick Piggin, Peter Zijlstra,
Arnaldo Carvalho de Melo, Paul Mackerras
Ingo,
Please pull the perf/urgent branch that can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
perf/urgent
If you think it's too late to get that into .37, I can still
rebase it to perf/core (or you can cherry-pick that patch
directly).
Thanks,
Frederic
---
Frederic Weisbecker (1):
perf: Fix callchain hit bad cast on ascii display
tools/perf/util/hist.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
commit d425de5436a620de506f9e4119bf8daa1cb93718
Author: Frederic Weisbecker <fweisbec@gmail.com>
Date: Mon Jan 3 16:13:11 2011 +0100
perf: Fix callchain hit bad cast on ascii display
ipchain__fprintf_graph() casts the number of hits in a branch as an
int, which means we lose its highests bits.
This results in meaningless number of callchain hits in perf.data
that have a high number of hits recorded, typically those that have
callchain branches hits appearing more than INT_MAX. This happens
easily as those are pondered by the event period.
Reported-by: Nick Piggin <npiggin@kernel.dk>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 2022e87..76bcc35 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -356,7 +356,7 @@ static size_t ipchain__fprintf_graph_line(FILE *fp, int depth, int depth_mask,
static size_t ipchain__fprintf_graph(FILE *fp, struct callchain_list *chain,
int depth, int depth_mask, int period,
- u64 total_samples, int hits,
+ u64 total_samples, u64 hits,
int left_margin)
{
int i;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-01-03 17:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-03 17:45 [GIT PULL] perf callchain fixlet Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®