* [PATCH] scripts/checkpatch.pl: reset rpt_cleaners warnings
@ 2011-01-10 10:53 Mike Frysinger
2011-02-02 0:42 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2011-01-10 10:53 UTC (permalink / raw)
To: Andy Whitcroft; +Cc: linux-kernel
If you run checkpatch against multiple patches, and one of them has a
whitespace issue which can be helped via a script (rpt_cleaners), you
will see the same NOTE over and over for all subsequent patches. It
makes it seem like those patches also have whitespace problems when in
reality, there's only one or two bad apples.
So reset rpt_cleaners back to 0 after we've issued the note so that it
only shows up near the patch with the actual problems.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
scripts/checkpatch.pl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e3c7fc0..94aba76 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2934,6 +2934,7 @@ sub process {
if ($rpt_cleaners) {
print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
print " scripts/cleanfile\n\n";
+ $rpt_cleaners = 0;
}
}
--
1.7.4.rc1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] scripts/checkpatch.pl: reset rpt_cleaners warnings
2011-01-10 10:53 [PATCH] scripts/checkpatch.pl: reset rpt_cleaners warnings Mike Frysinger
@ 2011-02-02 0:42 ` Mike Frysinger
2011-03-22 14:53 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2011-02-02 0:42 UTC (permalink / raw)
To: Andrew Morton; +Cc: Andy Whitcroft, linux-kernel
If you run checkpatch against multiple patches, and one of them has a
whitespace issue which can be helped via a script (rpt_cleaners), you
will see the same NOTE over and over for all subsequent patches. It
makes it seem like those patches also have whitespace problems when in
reality, there's only one or two bad apples.
So reset rpt_cleaners back to 0 after we've issued the note so that it
only shows up near the patch with the actual problems.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
Andrew: could you pick this up ? was sent out a few weeks ago ...
scripts/checkpatch.pl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e3c7fc0..94aba76 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2934,6 +2934,7 @@ sub process {
if ($rpt_cleaners) {
print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
print " scripts/cleanfile\n\n";
+ $rpt_cleaners = 0;
}
}
--
1.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/checkpatch.pl: reset rpt_cleaners warnings
2011-02-02 0:42 ` Mike Frysinger
@ 2011-03-22 14:53 ` Mike Frysinger
0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2011-03-22 14:53 UTC (permalink / raw)
To: Andrew Morton; +Cc: Andy Whitcroft, linux-kernel
On Tue, Feb 1, 2011 at 19:42, Mike Frysinger wrote:
> If you run checkpatch against multiple patches, and one of them has a
> whitespace issue which can be helped via a script (rpt_cleaners), you
> will see the same NOTE over and over for all subsequent patches. It
> makes it seem like those patches also have whitespace problems when in
> reality, there's only one or two bad apples.
>
> So reset rpt_cleaners back to 0 after we've issued the note so that it
> only shows up near the patch with the actual problems.
ping ...
-mike
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-22 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-10 10:53 [PATCH] scripts/checkpatch.pl: reset rpt_cleaners warnings Mike Frysinger
2011-02-02 0:42 ` Mike Frysinger
2011-03-22 14:53 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®