Re: [tip:perf/urgent] tracing: Include module.h in define_trace.h

[Steven Rostedt <rostedt@goodmis.org>]

On Mon, 2011-01-10 at 09:52 -0500, Steven Rostedt wrote:

> >   LD      vmlinux.o
> > kernel/built-in.o:(__tracepoints+0xac0): multiple definition of `__tracepoint_module_request'
> > arch/x86/built-in.o:(__tracepoints+0x100): first defined here
> > kernel/built-in.o:(__tracepoints+0xa40): multiple definition of `__tracepoint_module_get'
> > arch/x86/built-in.o:(__tracepoints+0x80): first defined here
> > kernel/built-in.o:(__tracepoints+0x9c0): multiple definition of `__tracepoint_module_load'
> > arch/x86/built-in.o:(__tracepoints+0x0): first defined here
> > kernel/built-in.o:(__tracepoints+0xa80): multiple definition of `__tracepoint_module_put'
> > arch/x86/built-in.o:(__tracepoints+0xc0): first defined here
> > kernel/built-in.o:(__tracepoints+0xa00): multiple definition of `__tracepoint_module_free'
> > arch/x86/built-in.o:(__tracepoints+0x40): first defined here
> 
> Hmm, OK, I'm able to reproduce it when I add:

Correction, I only reproduced this because I'm an idiot ;-)

> 
> #define CREATE_TRACE_POINTS
> #include <trace/events/syscalls.h>
> #undef CREATE_TRACE_POINTS
> 
> as the first thing in ptrace.c. I'll investigate this further.

I added this, but forgot to remove:

#define CREATE_TRACE_POINTS
#include <trace/events/syscalls.h>

that is at the bottom, causing the duplicate definitions.

Removing the second installation, it complies fine.

Thus, it works fine for me. :-/

-- Steve