mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: linux-kernel@vger.kernel.org, gregkh@suse.de,
	alan@linux.intel.com, akpm@linux-foundation.org
Cc: Feng Tang <feng.tang@intel.com>
Subject: [PATCH] console: prevent registered consoles from dumping old kernel message over again
Date: Wed, 12 Jan 2011 14:48:46 +0800	[thread overview]
Message-ID: <1294814926-1460-1-git-send-email-feng.tang@intel.com> (raw)

For a platform with many consoles like:
 "console=tty1 console=ttyMFD2 console=ttyS0 earlyprintk=mrst"

Each time when the non "selected_console" (tty1 and ttyMFD2 here) get
registered, the existing kernel message will be printed out on registered
consoles again, the "mrst" early console will get some same message for
3 times, and "tty1" will get some for twice.

So try to temporarily disable registered console's printing when dump the
existing kernel messages to the new console.

Signed-off-by: Feng Tang <feng.tang@intel.com>
---
 kernel/printk.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/kernel/printk.c b/kernel/printk.c
index f64b899..ba7186b 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -1245,6 +1245,7 @@ void register_console(struct console *newcon)
 	int i;
 	unsigned long flags;
 	struct console *bcon = NULL;
+	struct console *con;
 
 	/*
 	 * before we register a new CON_BOOT console, make sure we don't
@@ -1357,8 +1358,20 @@ void register_console(struct console *newcon)
 		spin_lock_irqsave(&logbuf_lock, flags);
 		con_start = log_start;
 		spin_unlock_irqrestore(&logbuf_lock, flags);
+
+		/*
+		 * Disable the existing consoles temporarily to prevent it from
+		 * printing out kernel log again.
+		 */
+		for_each_console(con)
+			if (con != newcon)
+				con->flags &= ~CON_ENABLED;
 	}
 	release_console_sem();
+
+	for_each_console(con)
+		con->flags |= CON_ENABLED;
+
 	console_sysfs_notify();
 
 	/*
-- 
1.7.0.4


             reply	other threads:[~2011-01-12  6:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12  6:48 Feng Tang [this message]
2011-01-12 11:14 ` Alan Cox
2011-01-12 14:51   ` Feng Tang
2011-01-12 14:50     ` Alan Cox
2011-01-20  0:11 ` Andrew Morton
2011-01-20  1:44   ` Feng Tang
2011-01-20  1:51     ` Andrew Morton
2011-01-20  2:31       ` Feng Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294814926-1460-1-git-send-email-feng.tang@intel.com \
    --to=feng.tang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®