[PATCH] target: remove duplicate include of target/target_core_device.h from drivers/target/target_core_hba.c

[PATCH] target: remove duplicate include of target/target_core_device.h from drivers/target/target_core_hba.c

[Jesper Juhl]

drivers/target/target_core_hba.c includes target/target_core_device.h 
twice - the two includes are even on two lines next to each other.
This patch removes the duplicate include.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 target_core_hba.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/target/target_core_hba.c b/drivers/target/target_core_hba.c
index 4bbe820..74d84f7 100644
--- a/drivers/target/target_core_hba.c
+++ b/drivers/target/target_core_hba.c
@@ -38,7 +38,6 @@
 
 #include <target/target_core_base.h>
 #include <target/target_core_device.h>
-#include <target/target_core_device.h>
 #include <target/target_core_tpg.h>
 #include <target/target_core_transport.h>
 

-- 
Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

Re: [PATCH] target: remove duplicate include of target/target_core_device.h from drivers/target/target_core_hba.c

[Nicholas A. Bellinger]

On Mon, 2011-01-17 at 22:46 +0100, Jesper Juhl wrote:
> drivers/target/target_core_hba.c includes target/target_core_device.h 
> twice - the two includes are even on two lines next to each other.
> This patch removes the duplicate include.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Committed as:

[linus-38-rc1 95f39d1] target: remove duplicate include target_core_device.h

Please let me know if you have more include cleanups so they can be git
squashed'  into a single commit for scsi-post-merge-2.6.git/for-jejb.

Thanks!

--nab


> ---
>  target_core_hba.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/target/target_core_hba.c b/drivers/target/target_core_hba.c
> index 4bbe820..74d84f7 100644
> --- a/drivers/target/target_core_hba.c
> +++ b/drivers/target/target_core_hba.c
> @@ -38,7 +38,6 @@
>  
>  #include <target/target_core_base.h>
>  #include <target/target_core_device.h>
> -#include <target/target_core_device.h>
>  #include <target/target_core_tpg.h>
>  #include <target/target_core_transport.h>
>  
> 

Re: [PATCH] target: remove duplicate include of target/target_core_device.h from drivers/target/target_core_hba.c

[Jesper Juhl]

On Mon, 17 Jan 2011, Nicholas A. Bellinger wrote:

> On Mon, 2011-01-17 at 22:46 +0100, Jesper Juhl wrote:
> > drivers/target/target_core_hba.c includes target/target_core_device.h 
> > twice - the two includes are even on two lines next to each other.
> > This patch removes the duplicate include.
> > 
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> 
> Committed as:
> 
> [linus-38-rc1 95f39d1] target: remove duplicate include target_core_device.h
> 
> Please let me know if you have more include cleanups so they can be git
> squashed'  into a single commit for scsi-post-merge-2.6.git/for-jejb.
> 
I only found that one so far...

-- 
Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

Re: [PATCH] target: remove duplicate include of target/target_core_device.h from drivers/target/target_core_hba.c

[Nicholas A. Bellinger]

On Mon, 2011-01-17 at 23:26 +0100, Jesper Juhl wrote:
> On Mon, 17 Jan 2011, Nicholas A. Bellinger wrote:
> 
> > On Mon, 2011-01-17 at 22:46 +0100, Jesper Juhl wrote:
> > > drivers/target/target_core_hba.c includes target/target_core_device.h 
> > > twice - the two includes are even on two lines next to each other.
> > > This patch removes the duplicate include.
> > > 
> > > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> > 
> > Committed as:
> > 
> > [linus-38-rc1 95f39d1] target: remove duplicate include target_core_device.h
> > 
> > Please let me know if you have more include cleanups so they can be git
> > squashed'  into a single commit for scsi-post-merge-2.6.git/for-jejb.
> > 
> I only found that one so far...
> 

<nod>  So for minor stuff like this (especially when the merge window is
winding down) feel tree to send this to me directly and CC linux-scsi
and I will make sure this gets in via scsi-post-merge-2.6.git/for-jejb.

--nab