From: Glauber Costa <glommer@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
aliguori@us.ibm.com, Rik van Riel <riel@redhat.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 16/16] KVM-GST: adjust scheduler cpu power
Date: Mon, 24 Jan 2011 17:57:11 -0200 [thread overview]
Message-ID: <1295899031.15920.13.camel@mothafucka.localdomain> (raw)
In-Reply-To: <1295898690.28776.472.camel@laptop>
On Mon, 2011-01-24 at 20:51 +0100, Peter Zijlstra wrote:
> On Mon, 2011-01-24 at 16:51 -0200, Glauber Costa wrote:
> > > I would really much rather see you change update_rq_clock_task() and
> > > subtract your ns resolution steal time from our wall-time,
> > > update_rq_clock_task() already updates the cpu_power relative to the
> > > remaining time available.
> >
> > But then we get into the problems we already discussed in previous
> > submissions, which is, we don't really want to alter any notion of
> > wallclock time. Could you list any more concrete advantages of the
> > specific way you proposed?
>
> clock_task is the time spend on the task, by not taking steal time into
> account all steal time is accounted as service to whatever task was
> current when the vcpu wasn't running.
>
> It doesn't change wall-time in the sense of gtod, only the service time
> to tasks.
Ok, I'll experiment with that and see how it goes.
next prev parent reply other threads:[~2011-01-24 19:57 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 18:06 [PATCH 00/16] New Proposal for steal time in KVM Glauber Costa
2011-01-24 18:06 ` [PATCH 01/16] KVM-HDR: register KVM basic header infrastructure Glauber Costa
2011-01-26 11:06 ` Avi Kivity
2011-01-26 12:13 ` Glauber Costa
2011-01-26 15:12 ` Avi Kivity
2011-01-26 15:36 ` Glauber Costa
2011-01-26 17:22 ` Anthony Liguori
2011-01-26 17:49 ` Glauber Costa
2011-01-27 12:31 ` Avi Kivity
2011-01-24 18:06 ` [PATCH 02/16] KVM-HV: KVM - KVM Virtual Memory hypervisor implementation Glauber Costa
2011-01-24 18:06 ` [PATCH 03/16] KVM-HDR: KVM Userspace registering ioctl Glauber Costa
2011-01-26 11:12 ` Avi Kivity
2011-01-26 12:14 ` Glauber Costa
2011-01-26 15:14 ` Avi Kivity
2011-01-26 15:23 ` Glauber Costa
2011-01-24 18:06 ` [PATCH 04/16] KVM-HV: " Glauber Costa
2011-01-24 18:06 ` [PATCH 05/16] KVM-HDR: Implement wallclock over KVM - KVM Virtual Memory Glauber Costa
2011-01-26 11:13 ` Avi Kivity
2011-01-26 12:20 ` Glauber Costa
2011-01-26 15:17 ` Avi Kivity
2011-01-26 15:45 ` Glauber Costa
2011-01-27 12:17 ` Avi Kivity
2011-01-24 18:06 ` [PATCH 06/16] " Glauber Costa
2011-01-24 18:06 ` [PATCH 07/16] KVM-GST: " Glauber Costa
2011-01-24 18:06 ` [PATCH 08/16] KVM-HDR: Implement kvmclock systemtime " Glauber Costa
2011-01-24 18:06 ` [PATCH 09/16] KVM-HV: " Glauber Costa
2011-01-24 18:06 ` [PATCH 10/16] KVM-GST: " Glauber Costa
2011-01-24 18:06 ` [PATCH 11/16] KVM-HDR: KVM Steal time implementation Glauber Costa
2011-01-24 23:06 ` Rik van Riel
2011-01-24 18:06 ` [PATCH 12/16] KVM-HV: " Glauber Costa
2011-01-24 23:15 ` Rik van Riel
2011-01-24 18:06 ` [PATCH 13/16] KVM-HV: KVM Steal time calculation Glauber Costa
2011-01-24 23:20 ` Rik van Riel
2011-01-24 18:06 ` [PATCH 14/16] KVM-GST: KVM Steal time registration Glauber Costa
2011-01-24 23:27 ` Rik van Riel
2011-01-24 23:31 ` Rik van Riel
2011-01-25 1:25 ` Glauber Costa
2011-01-25 1:26 ` Rik van Riel
2011-01-25 1:28 ` Glauber Costa
2011-01-24 18:06 ` [PATCH 15/16] KVM-GST: KVM Steal time accounting Glauber Costa
2011-01-24 23:33 ` Rik van Riel
2011-01-24 18:06 ` [PATCH 16/16] KVM-GST: adjust scheduler cpu power Glauber Costa
2011-01-24 18:32 ` Peter Zijlstra
2011-01-24 18:51 ` Glauber Costa
2011-01-24 19:51 ` Peter Zijlstra
2011-01-24 19:57 ` Glauber Costa [this message]
2011-01-25 20:02 ` Glauber Costa
2011-01-25 20:13 ` Peter Zijlstra
2011-01-25 20:47 ` Glauber Costa
2011-01-25 21:07 ` Peter Zijlstra
2011-01-25 21:27 ` Glauber Costa
2011-01-26 9:57 ` Peter Zijlstra
2011-01-26 15:43 ` Glauber Costa
2011-01-26 16:46 ` Peter Zijlstra
2011-01-26 16:53 ` Peter Zijlstra
2011-01-26 18:11 ` Glauber Costa
2011-01-24 19:53 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295899031.15920.13.camel@mothafucka.localdomain \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®