mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] soc: qcom: pmic_glink: Increase max ports to 3
@ 2024-05-27  8:16 Abel Vesa
  2024-05-27  8:21 ` neil.armstrong
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Abel Vesa @ 2024-05-27  8:16 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio; +Cc: linux-arm-msm, linux-kernel, Abel Vesa

Up until now, all Qualcomm platforms only had maximum 2 ports. The X Elite
(x1e80100) adds a third one. Increase the maximum allowed to 3.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 drivers/soc/qcom/pmic_glink_altmode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c
index b3808fc24c69..1e0808b3cb93 100644
--- a/drivers/soc/qcom/pmic_glink_altmode.c
+++ b/drivers/soc/qcom/pmic_glink_altmode.c
@@ -20,7 +20,7 @@
 
 #include <linux/soc/qcom/pmic_glink.h>
 
-#define PMIC_GLINK_MAX_PORTS	2
+#define PMIC_GLINK_MAX_PORTS	3
 
 #define USBC_SC8180X_NOTIFY_IND	0x13
 #define USBC_CMD_WRITE_REQ      0x15

---
base-commit: 3689b0ef08b70e4e03b82ebd37730a03a672853a
change-id: 20240522-x1e80100-soc-qcom-pmic-glink-f3b715fe5f90

Best regards,
-- 
Abel Vesa <abel.vesa@linaro.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] soc: qcom: pmic_glink: Increase max ports to 3
  2024-05-27  8:16 [PATCH] soc: qcom: pmic_glink: Increase max ports to 3 Abel Vesa
@ 2024-05-27  8:21 ` neil.armstrong
  2024-05-27  9:06 ` Dmitry Baryshkov
  2024-05-28  3:32 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: neil.armstrong @ 2024-05-27  8:21 UTC (permalink / raw)
  To: Abel Vesa, Bjorn Andersson, Konrad Dybcio; +Cc: linux-arm-msm, linux-kernel

On 27/05/2024 10:16, Abel Vesa wrote:
> Up until now, all Qualcomm platforms only had maximum 2 ports. The X Elite
> (x1e80100) adds a third one. Increase the maximum allowed to 3.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>   drivers/soc/qcom/pmic_glink_altmode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c
> index b3808fc24c69..1e0808b3cb93 100644
> --- a/drivers/soc/qcom/pmic_glink_altmode.c
> +++ b/drivers/soc/qcom/pmic_glink_altmode.c
> @@ -20,7 +20,7 @@
>   
>   #include <linux/soc/qcom/pmic_glink.h>
>   
> -#define PMIC_GLINK_MAX_PORTS	2
> +#define PMIC_GLINK_MAX_PORTS	3
>   
>   #define USBC_SC8180X_NOTIFY_IND	0x13
>   #define USBC_CMD_WRITE_REQ      0x15
> 
> ---
> base-commit: 3689b0ef08b70e4e03b82ebd37730a03a672853a
> change-id: 20240522-x1e80100-soc-qcom-pmic-glink-f3b715fe5f90
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] soc: qcom: pmic_glink: Increase max ports to 3
  2024-05-27  8:16 [PATCH] soc: qcom: pmic_glink: Increase max ports to 3 Abel Vesa
  2024-05-27  8:21 ` neil.armstrong
@ 2024-05-27  9:06 ` Dmitry Baryshkov
  2024-05-28  3:32 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2024-05-27  9:06 UTC (permalink / raw)
  To: Abel Vesa; +Cc: Bjorn Andersson, Konrad Dybcio, linux-arm-msm, linux-kernel

On Mon, May 27, 2024 at 11:16:01AM +0300, Abel Vesa wrote:
> Up until now, all Qualcomm platforms only had maximum 2 ports. The X Elite
> (x1e80100) adds a third one. Increase the maximum allowed to 3.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  drivers/soc/qcom/pmic_glink_altmode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] soc: qcom: pmic_glink: Increase max ports to 3
  2024-05-27  8:16 [PATCH] soc: qcom: pmic_glink: Increase max ports to 3 Abel Vesa
  2024-05-27  8:21 ` neil.armstrong
  2024-05-27  9:06 ` Dmitry Baryshkov
@ 2024-05-28  3:32 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2024-05-28  3:32 UTC (permalink / raw)
  To: Konrad Dybcio, Abel Vesa; +Cc: linux-arm-msm, linux-kernel


On Mon, 27 May 2024 11:16:01 +0300, Abel Vesa wrote:
> Up until now, all Qualcomm platforms only had maximum 2 ports. The X Elite
> (x1e80100) adds a third one. Increase the maximum allowed to 3.
> 
> 

Applied, thanks!

[1/1] soc: qcom: pmic_glink: Increase max ports to 3
      commit: a8a313c298b8becc7e2c0bab174df736d1f99450

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-05-28  3:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-27  8:16 [PATCH] soc: qcom: pmic_glink: Increase max ports to 3 Abel Vesa
2024-05-27  8:21 ` neil.armstrong
2024-05-27  9:06 ` Dmitry Baryshkov
2024-05-28  3:32 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®