mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "J.P. Lacerda" <jp.lacerda@codethink.co.uk>
To: <akpm@linux-foundation.org>, <johan.wessfeldt@gmail.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <x86@kernel.org>,
	linux-kernel@vger.kernel.org
Cc: "J.P. Lacerda" <jp.lacerda@codethink.co.uk>
Subject: [PATCH 1/1] x86: Fix mcheck_init_device() to handle misc_register() correctly
Date: Fri,  4 Mar 2011 13:29:27 +0000	[thread overview]
Message-ID: <1299245367-20279-1-git-send-email-jp.lacerda@codethink.co.uk> (raw)

The return value for misc_register() was not being taken into account.
Furthermore, if misc_register() fails, we must rollback any changes made by
mcheck_init_device()

Signed-off-by: J.P. Lacerda <jp.lacerda@codethink.co.uk>
---
 arch/x86/kernel/cpu/mcheck/mce.c |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index d916183..20c2c44 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -2140,7 +2140,18 @@ static __init int mcheck_init_device(void)
 	}
 
 	register_hotcpu_notifier(&mce_cpu_notifier);
-	misc_register(&mce_log_device);
+	err = misc_register(&mce_log_device);
+
+	if (err) {
+		unregister_hotcpu_notifier(&mce_cpu_notifier);
+
+		for_each_online_cpu(i) {
+			mce_remove_device(i);
+		}
+
+		sysdev_class_unregister(&mce_sysclass);
+		free_cpumask_var(mce_dev_initialized);
+	}
 
 	return err;
 }
-- 
1.7.1


             reply	other threads:[~2011-03-04 13:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-04 13:29 J.P. Lacerda [this message]
2011-03-04 17:16 ` Borislav Petkov
2011-03-04 21:07   ` Johan Wessfeldt
2011-03-05 12:56     ` Borislav Petkov
2011-03-04 18:17 ` Dan Carpenter
2011-03-04 21:38 ` Johan Wessfeldt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299245367-20279-1-git-send-email-jp.lacerda@codethink.co.uk \
    --to=jp.lacerda@codethink.co.uk \
    --cc=akpm@linux-foundation.org \
    --cc=johan.wessfeldt@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®