From: Borislav Petkov <bp@amd64.org>
To: "J.P. Lacerda" <jp.lacerda@codethink.co.uk>
Cc: akpm@linux-foundation.org, johan.wessfeldt@gmail.com,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] x86: Fix mcheck_init_device() to handle misc_register() correctly
Date: Fri, 4 Mar 2011 18:16:19 +0100 [thread overview]
Message-ID: <20110304171619.GB9311@gere.osrc.amd.com> (raw)
In-Reply-To: <1299245367-20279-1-git-send-email-jp.lacerda@codethink.co.uk>
On Fri, Mar 04, 2011 at 01:29:27PM +0000, J.P. Lacerda wrote:
> The return value for misc_register() was not being taken into account.
> Furthermore, if misc_register() fails, we must rollback any changes made by
> mcheck_init_device()
If you're going to fix all error paths here, you still need to handle
unrolling the setup done by mce_create_device() if we fail somewhere in
between.
> Signed-off-by: J.P. Lacerda <jp.lacerda@codethink.co.uk>
> ---
> arch/x86/kernel/cpu/mcheck/mce.c | 13 ++++++++++++-
> 1 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
> index d916183..20c2c44 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> @@ -2140,7 +2140,18 @@ static __init int mcheck_init_device(void)
> }
>
> register_hotcpu_notifier(&mce_cpu_notifier);
> - misc_register(&mce_log_device);
> + err = misc_register(&mce_log_device);
> +
no newline here.
> + if (err) {
> + unregister_hotcpu_notifier(&mce_cpu_notifier);
> +
> + for_each_online_cpu(i) {
> + mce_remove_device(i);
> + }
no need for braces around a single loop body statement.
> +
> + sysdev_class_unregister(&mce_sysclass);
> + free_cpumask_var(mce_dev_initialized);
> + }
>
> return err;
Anyway, while this is makes sense from correctness POV, if we hit an
error path here this early then something else is going terribly wrong
which would've screamed very loudly already. Are you hitting this on a
real workload or you caught this by code staring?
Because if it is the second case, the merit of fixing those error
paths vs adding code which is almost never executed is significantly
diminished.
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-03-04 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 13:29 J.P. Lacerda
2011-03-04 17:16 ` Borislav Petkov [this message]
2011-03-04 21:07 ` Johan Wessfeldt
2011-03-05 12:56 ` Borislav Petkov
2011-03-04 18:17 ` Dan Carpenter
2011-03-04 21:38 ` Johan Wessfeldt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304171619.GB9311@gere.osrc.amd.com \
--to=bp@amd64.org \
--cc=akpm@linux-foundation.org \
--cc=johan.wessfeldt@gmail.com \
--cc=jp.lacerda@codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®