* [GIT PULL 0/1] perf/urgent fix
@ 2011-03-09 22:57 Arnaldo Carvalho de Melo
2011-03-09 22:57 ` [PATCH 1/1] perf symbols: Avoid resolving [kernel.kallsyms] to real path for buildid cache Arnaldo Carvalho de Melo
2011-03-10 6:34 ` [GIT PULL 0/1] perf/urgent fix Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-03-09 22:57 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Han Pingtian,
Ingo Molnar, Lin Ming, Peter Zijlstra, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/urgent
Regards,
- Arnaldo
Lin Ming (1):
perf symbols: Avoid resolving [kernel.kallsyms] to real path for buildid cache
tools/perf/util/header.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 1/1] perf symbols: Avoid resolving [kernel.kallsyms] to real path for buildid cache 2011-03-09 22:57 [GIT PULL 0/1] perf/urgent fix Arnaldo Carvalho de Melo @ 2011-03-09 22:57 ` Arnaldo Carvalho de Melo 2011-03-10 6:34 ` [GIT PULL 0/1] perf/urgent fix Ingo Molnar 1 sibling, 0 replies; 3+ messages in thread From: Arnaldo Carvalho de Melo @ 2011-03-09 22:57 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Lin Ming, Han Pingtian, Ingo Molnar, Peter Zijlstra, Arnaldo Carvalho de Melo From: Lin Ming <ming.m.lin@intel.com> kallsyms has a virtual file name [kernel.kallsyms]. Currently, it can't be added to buildid cache successfully because the code (build_id_cache__add_s) tries to resolve [kernel.kallsyms] to a real absolute pathname and that fails. Fixes it by not resolving it and just use the name [kernel.kallsyms]. So dir ~/.debug/[kernel.kallsyms] is created. Original bug report at: https://lkml.org/lkml/2011/3/1/524 Tested-by: Han Pingtian <phan@redhat.com> Cc: Han Pingtian <phan@redhat.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> LKML-Reference: <1299165837-27817-1-git-send-email-ming.m.lin@intel.com> Signed-off-by: Lin Ming <ming.m.lin@intel.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/header.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index f6a929e..0866bcd 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -270,11 +270,15 @@ int build_id_cache__add_s(const char *sbuild_id, const char *debugdir, const char *name, bool is_kallsyms) { const size_t size = PATH_MAX; - char *realname = realpath(name, NULL), - *filename = malloc(size), + char *realname, *filename = malloc(size), *linkname = malloc(size), *targetname; int len, err = -1; + if (is_kallsyms) + realname = (char *)name; + else + realname = realpath(name, NULL); + if (realname == NULL || filename == NULL || linkname == NULL) goto out_free; @@ -306,7 +310,8 @@ int build_id_cache__add_s(const char *sbuild_id, const char *debugdir, if (symlink(targetname, linkname) == 0) err = 0; out_free: - free(realname); + if (!is_kallsyms) + free(realname); free(filename); free(linkname); return err; -- 1.6.2.5 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL 0/1] perf/urgent fix 2011-03-09 22:57 [GIT PULL 0/1] perf/urgent fix Arnaldo Carvalho de Melo 2011-03-09 22:57 ` [PATCH 1/1] perf symbols: Avoid resolving [kernel.kallsyms] to real path for buildid cache Arnaldo Carvalho de Melo @ 2011-03-10 6:34 ` Ingo Molnar 1 sibling, 0 replies; 3+ messages in thread From: Ingo Molnar @ 2011-03-10 6:34 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-kernel, Han Pingtian, Lin Ming, Peter Zijlstra, Arnaldo Carvalho de Melo * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > Hi Ingo, > > Please consider pulling from: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/urgent > > Regards, > > - Arnaldo > > Lin Ming (1): > perf symbols: Avoid resolving [kernel.kallsyms] to real path for buildid cache > > tools/perf/util/header.c | 11 ++++++++--- > 1 files changed, 8 insertions(+), 3 deletions(-) Pulled, thanks a lot Arnaldo! Ingo ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-10 6:34 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2011-03-09 22:57 [GIT PULL 0/1] perf/urgent fix Arnaldo Carvalho de Melo 2011-03-09 22:57 ` [PATCH 1/1] perf symbols: Avoid resolving [kernel.kallsyms] to real path for buildid cache Arnaldo Carvalho de Melo 2011-03-10 6:34 ` [GIT PULL 0/1] perf/urgent fix Ingo Molnar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®