mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 03/14] xen: events: simplify comment
Date: Thu, 10 Mar 2011 16:08:04 +0000	[thread overview]
Message-ID: <1299773295-348-3-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1299773279.17339.813.camel@zakaz.uk.xensource.com>

It is never valid assume any particular relationship between a Xen
PIRQ number and and Linux IRQ number so there is no need to hedge when
saying so.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 drivers/xen/events.c |   10 +++-------
 include/xen/events.h |    4 +---
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index 2ce95a6..a9c154d 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -583,13 +583,9 @@ int xen_allocate_pirq(unsigned gsi, int shareable, char *name)
 	return xen_map_pirq_gsi(gsi, gsi, shareable, name);
 }
 
-/* xen_map_pirq_gsi might allocate irqs from the top down, as a
- * consequence don't assume that the irq number returned has a low value
- * or can be used as a pirq number unless you know otherwise.
- *
- * One notable exception is when xen_map_pirq_gsi is called passing an
- * hardware gsi as argument, in that case the irq number returned
- * matches the gsi number passed as second argument.
+/*
+ * Do not make any assumptions regarding the relationship between the
+ * IRQ number returned here and the Xen pirq argument.
  *
  * Note: We don't assign an event channel until the irq actually started
  * up.  Return an existing irq if we've already got one for the gsi.
diff --git a/include/xen/events.h b/include/xen/events.h
index 962da2c..f6fed94 100644
--- a/include/xen/events.h
+++ b/include/xen/events.h
@@ -68,9 +68,7 @@ int xen_set_callback_via(uint64_t via);
 void xen_evtchn_do_upcall(struct pt_regs *regs);
 void xen_hvm_evtchn_do_upcall(void);
 
-/* Allocate an irq for a physical interrupt, given a gsi.  "Legacy"
- * GSIs are identity mapped; others are dynamically allocated as
- * usual. */
+/* Allocate an irq for a physical interrupt, given a gsi. */
 int xen_allocate_pirq(unsigned gsi, int shareable, char *name);
 int xen_map_pirq_gsi(unsigned pirq, unsigned gsi, int shareable, char *name);
 
-- 
1.5.6.5


  parent reply	other threads:[~2011-03-10 16:08 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 16:07 [GIT PATCH v2 0/14] xen: events: cleanups + ween off nr_irqs Ian Campbell
2011-03-10 16:08 ` [PATCH 01/14] xen: events: separate two unrelated halves of if condition Ian Campbell
2011-03-10 16:08 ` [PATCH 02/14] xen: events: fix xen_map_pirq_gsi error return Ian Campbell
2011-03-10 16:08 ` Ian Campbell [this message]
2011-03-10 16:08 ` [PATCH 04/14] xen: events: remove unused public functions Ian Campbell
2011-03-10 16:08 ` [PATCH 05/14] xen: events: rename restore_cpu_pirqs -> restore_pirqs Ian Campbell
2011-03-10 16:08 ` [PATCH 06/14] xen: events: refactor GSI pirq bindings functions Ian Campbell
2011-03-10 16:08 ` [PATCH 07/14] xen: events: use per-cpu variable for cpu_evtchn_mask Ian Campbell
2011-03-10 16:08 ` [PATCH 08/14] xen: events: turn irq_info constructors into initialiser functions Ian Campbell
2011-03-10 16:08 ` [PATCH 09/14] xen: events: push setup of irq<->{evtchn,ipi,virq,pirq} maps into irq_info init functions Ian Campbell
2011-03-10 16:08 ` [PATCH 10/14] xen: events: maintain a list of Xen interrupts Ian Campbell
2011-03-10 16:08 ` [PATCH 11/14] xen: events: dynamically allocate irq info structures Ian Campbell
2011-03-10 16:08 ` [PATCH 12/14] xen: events: remove use of nr_irqs as upper bound on number of pirqs Ian Campbell
2011-03-10 16:08 ` [PATCH 13/14] xen: events: do not workaround too-small nr_irqs Ian Campbell
2011-03-10 16:08 ` [PATCH 14/14] xen: events: propagate irq allocation failure instead of panicking Ian Campbell
2011-03-10 22:57 ` [GIT PATCH v2 0/14] xen: events: cleanups + ween off nr_irqs Konrad Rzeszutek Wilk
2011-03-10 23:23   ` Konrad Rzeszutek Wilk
2011-03-11  9:14     ` Ian Campbell
2011-03-11  0:38   ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-03-11  9:17     ` Ian Campbell
2011-03-11  9:12   ` Ian Campbell
2011-03-11 11:24     ` [Xen-devel] " Ian Campbell
2011-03-11 13:28       ` Ian Campbell
2011-03-11 14:24         ` Ian Campbell
2011-03-11 14:32           ` Ian Campbell
2011-03-11 14:46             ` Ian Campbell
2011-03-11 14:29         ` Konrad Rzeszutek Wilk
2011-03-11 14:46           ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2011-03-09 17:40 [GIT PATCH " Ian Campbell
2011-03-09 17:41 ` [PATCH 03/14] xen: events: simplify comment Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299773295-348-3-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®