mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "chengjian (D)" <cj.chengjian@huawei.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <huawei.libin@huawei.com>
Subject: Re: [PATCH] arm64: Convert pr_warning to standard pr_warn
Date: Tue, 5 Sep 2017 17:22:26 +0800	[thread overview]
Message-ID: <12ad3ebb-191b-b753-a773-250b0992f1c2@huawei.com> (raw)
In-Reply-To: <20170905091051.GA4401@leverpostej>

Hi Mark,

OK, I will do it now



> On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
>> Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
>>
>> Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
>> ---
>>   arch/arm64/kernel/smp.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> Is this a step towards removing pr_warning entirely?
>
> If so, can you please fix up all occurences in arm64? i.e.
>
> [mark@leverpostej:~/src/linux]% git grep pr_warning linux-next/master:arch/arm64
> linux-next/master:arch/arm64:include/asm/syscall.h:             pr_warning("%s called with max args %d, handling only %d\n",
> linux-next/master:arch/arm64:include/asm/syscall.h:             pr_warning("%s called with max args %d, handling only %d\n",
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("unknown slot type: %d\n", type);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("attempt to read from unknown breakpoint register %d\n", n);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("attempt to write to unknown breakpoint register %d\n", n);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("invalid breakpoint privilege level %d\n", privilege);
> linux-next/master:arch/arm64:kernel/smp.c:              pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
> linux-next/master:arch/arm64:kernel/smp.c:              pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>
> Otherwise, I don't think it make sense to only fix some occurences.
>
> Thanks,
> Mark.
>
>> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
>> index 9f7195a..efcaa05 100644
>> --- a/arch/arm64/kernel/smp.c
>> +++ b/arch/arm64/kernel/smp.c
>> @@ -972,7 +972,7 @@ void smp_send_stop(void)
>>   		udelay(1);
>>   
>>   	if (num_online_cpus() > 1)
>> -		pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>> +		pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
>>   			   cpumask_pr_args(cpu_online_mask));
>>   }
>>   
>> @@ -1009,7 +1009,7 @@ void crash_smp_send_stop(void)
>>   		udelay(1);
>>   
>>   	if (atomic_read(&waiting_for_crash_ipi) > 0)
>> -		pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>> +		pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
>>   			   cpumask_pr_args(&mask));
>>   }
>>   
>> -- 
>> 1.8.3.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> .
>

  reply	other threads:[~2017-09-05  9:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05  2:28 chengjian c00427203
2017-09-05  9:10 ` Mark Rutland
2017-09-05  9:22   ` chengjian (D) [this message]
2017-09-05 18:38   ` Joe Perches
2017-09-06  9:21     ` Mark Rutland
2017-09-06 14:19       ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12ad3ebb-191b-b753-a773-250b0992f1c2@huawei.com \
    --to=cj.chengjian@huawei.com \
    --cc=huawei.libin@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®