* [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name()
@ 2025-05-09 15:01 Krzysztof Kozlowski
2025-05-09 18:28 ` Martin Blumenstingl
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-09 15:01 UTC (permalink / raw)
To: Xianwei Zhao, Linus Walleij, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt, linux-amlogic,
linux-gpio, linux-arm-kernel, linux-kernel, llvm
Cc: Krzysztof Kozlowski
aml_pctl_find_group_by_name() is not used anywhere, as reported by W=1
clang build:
pinctrl-amlogic-a4.c:600:2: error: unused function 'aml_pctl_find_group_by_name' [-Werror,-Wunused-function]
Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
index a76f266b4b94..385cc619df13 100644
--- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
+++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
@@ -596,20 +596,6 @@ static int aml_get_group_pins(struct pinctrl_dev *pctldev,
return 0;
}
-static inline const struct aml_pctl_group *
- aml_pctl_find_group_by_name(const struct aml_pinctrl *info,
- const char *name)
-{
- int i;
-
- for (i = 0; i < info->ngroups; i++) {
- if (!strcmp(info->groups[i].name, name))
- return &info->groups[i];
- }
-
- return NULL;
-}
-
static void aml_pin_dbg_show(struct pinctrl_dev *pcdev, struct seq_file *s,
unsigned int offset)
{
--
2.45.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name()
2025-05-09 15:01 [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name() Krzysztof Kozlowski
@ 2025-05-09 18:28 ` Martin Blumenstingl
2025-05-12 2:26 ` Xianwei Zhao
2025-05-13 21:52 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Martin Blumenstingl @ 2025-05-09 18:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Xianwei Zhao, Linus Walleij, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt, linux-amlogic, linux-gpio,
linux-arm-kernel, linux-kernel, llvm
On Fri, May 9, 2025 at 5:01 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> aml_pctl_find_group_by_name() is not used anywhere, as reported by W=1
> clang build:
>
> pinctrl-amlogic-a4.c:600:2: error: unused function 'aml_pctl_find_group_by_name' [-Werror,-Wunused-function]
>
> Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name()
2025-05-09 15:01 [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name() Krzysztof Kozlowski
2025-05-09 18:28 ` Martin Blumenstingl
@ 2025-05-12 2:26 ` Xianwei Zhao
2025-05-13 21:52 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Xianwei Zhao @ 2025-05-12 2:26 UTC (permalink / raw)
To: Krzysztof Kozlowski, Linus Walleij, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt, linux-amlogic,
linux-gpio, linux-arm-kernel, linux-kernel, llvm
Reviewed-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
On 2025/5/9 23:01, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> aml_pctl_find_group_by_name() is not used anywhere, as reported by W=1
> clang build:
>
> pinctrl-amlogic-a4.c:600:2: error: unused function 'aml_pctl_find_group_by_name' [-Werror,-Wunused-function]
>
> Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> index a76f266b4b94..385cc619df13 100644
> --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> @@ -596,20 +596,6 @@ static int aml_get_group_pins(struct pinctrl_dev *pctldev,
> return 0;
> }
>
> -static inline const struct aml_pctl_group *
> - aml_pctl_find_group_by_name(const struct aml_pinctrl *info,
> - const char *name)
> -{
> - int i;
> -
> - for (i = 0; i < info->ngroups; i++) {
> - if (!strcmp(info->groups[i].name, name))
> - return &info->groups[i];
> - }
> -
> - return NULL;
> -}
> -
> static void aml_pin_dbg_show(struct pinctrl_dev *pcdev, struct seq_file *s,
> unsigned int offset)
> {
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name()
2025-05-09 15:01 [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name() Krzysztof Kozlowski
2025-05-09 18:28 ` Martin Blumenstingl
2025-05-12 2:26 ` Xianwei Zhao
@ 2025-05-13 21:52 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2025-05-13 21:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Xianwei Zhao, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt, linux-amlogic, linux-gpio,
linux-arm-kernel, linux-kernel, llvm
On Fri, May 9, 2025 at 5:01 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> aml_pctl_find_group_by_name() is not used anywhere, as reported by W=1
> clang build:
>
> pinctrl-amlogic-a4.c:600:2: error: unused function 'aml_pctl_find_group_by_name' [-Werror,-Wunused-function]
>
> Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-13 21:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-09 15:01 [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name() Krzysztof Kozlowski
2025-05-09 18:28 ` Martin Blumenstingl
2025-05-12 2:26 ` Xianwei Zhao
2025-05-13 21:52 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®